There is no test suite about bsc HOT 9 CLOSED

Yes, as the README says, we hope to add a test suite. One exists, but it is not yet public. If you submit a PR, I will run the changes on the private test suite -- though I recognize that it would help to have regression tests prior to submitting the PR, so hopefully we can have something soon.

from bsc.

Thanks, sorry I missed that! That's great to know. Right now I have some changes queued up for doing builds with Nix, possibly some CI with GitHub actions, etc. Nothing material, we're just trying to get all the dependencies/build requirements sorted out reliably. I just wanted to try and fix our Nix builds to work with a more modern GHC -- since only 8.0.x seems to work, which we long since deprecated -- and was wondering how to test anything.

I don't know what y'alls plans are yet for some of the stuff like CI, but I can just submit some pulls and hash it out I suppose...

from bsc.

I'll also write a patch to at least run the smoke test under make check for now (and hopefully any future public test suite can be under that target name!) Many packaging systems use this as an implicit default target for doing integration tests (including ours), so making the default test do something keeps things simpler for everyone.

from bsc.

For what it's worth, it definitely builds (and runs the smoke test) with GHC 8.4.4 for me, so you can upgrade at least that far. I haven't tried anything newer yet.

from bsc.

Thanks, I have a working Nix build using 8.0.2, so I'll try an upgrade.

from bsc.

I've compiled with 8.8.2, and added in the necessary CPP macros to account for library versions and feature changes, so I think it should compile with later versions (I had a bad installation that wouldn't link, so I didn't run it, but it compiles). I think I also did the same with 8.6.5. And certainly with 8.4.4.

from bsc.

I've successfully built everything with 8.4.4, and removed STP support as well (which I suppose did fix things, I suppose!) So I think everything is in pretty good shape.

from bsc.

(Also: the patch for putting the smoke test inside make check is defined in #30, as well.)

from bsc.

Oh, I forgot to update this issue! We do now have an open testsuite, at bsc-testsuite

from bsc.