Comments (13)
@IzzySoft @linsui Sorry, I haven't had much time to get to this but I'm currently rewriting Resplash from scratch and should hopefully have an updated release soon.
from resplash.
Thanks! Great news!
from resplash.
A new apk has been uploaded for v3.0.0
from resplash.
@IzzySoft Thanks for the write-up! Removing these shouldn't affect the core functionality but unfortunately I don't really have the time or resources to support both versions right now. @LongJohn-Silver All the code is open source so you could fork this project and make it your own or submit a PR if this is something you really want.
from resplash.
@b-lam that's more than I dared hope for, thanks! May I suggest opening a corresponding issue with the label "help-needed"? Then those interested can jump in, fork, and provide the PR(s). You could also specify your preference, like
- I don't care, so just kick the crap out π
- please split it off using build flavors named
fdroid
andplay
(or whatever names you prefer) - mixed mode: just ditch βΆ but split off flavors for β·
Such an issue opened by you (the author and repo-owner) would carry some more weight than if someone else does it. It also eliminates the excuse "but I don't want to maintain a fork", as you explicitly state to accept (reasonable) PRs to integrate here β so after the merge, the contributor is "free" again (and the software remains free, of course π)
My repo should show the progress on each new release following such a merge (as multiple elements are effected, there could be multiple PRs, potentially, each focusing on one lib or a group of libs). Feel free to ping me if you think I can give some advice or should take a look if it would be ready to try on F-Droid.org.
from resplash.
Did you give up? Or just misread the 2.0.1
in my repo comparing it to the 2.1.0
in build.gradle
? I just wonder where that comes from. According to metadata, it must have been a tag which now is deleted but obviously existed in May 2019.
from resplash.
Thanks! Will show up in my repo tomorrow. Wow, and even got a bit slimmer, 1M less in size β just kick Crashlytics as well (it's phased out anyway) for another slimming, and you'll be below 6M again π
from resplash.
@IzzySoft Yup the rewrite definitely helped remove a bunch of unnecessary code and assets. Is Crashlytics being phased out? I think it is just Fabric Crashlytics that is being phased out for Firebase Crashlytics, which is what I have switched to.
from resplash.
Yes, that. I didn't check which one you had implemented. To me both are just proprietary trackers collecting user data on "other people's computers", sorry (well, I don't like my data stored with the "big collectors" like Google etc β no offense meant of course). Consider switching to some FOSS analytics instead? π There're e.g. ACRA, tracedroid and probably moreβ¦
from resplash.
What about publishing directly on F-droid? Any ideas about that?
from resplash.
@LongJohn-Silver not possible before Crashlytics was removed. F-Droid doesn't permit proprietary elements. The following things currently used are show-stoppers for a listing at F-Droid:
apply plugin: 'com.google.android.gms.oss-licenses-plugin'
apply plugin: 'com.google.firebase.crashlytics'
apply plugin: 'com.google.gms.google-services'
Before irritated questions arise: the first (oss-licenses-plugin) depends on the last (GMS), hence it is a show-stopper itself. Next:
implementation 'com.android.billingclient:billing:3.0.0'
Again depends on GMS.
// Firebase
implementation 'com.google.firebase:firebase-analytics-ktx:17.5.0'
implementation 'com.google.firebase:firebase-crashlytics:17.2.1'
implementation 'com.google.firebase:firebase-inappmessaging-ktx:19.1.1'
implementation 'com.google.firebase:firebase-firestore-ktx:21.6.0'
implementation 'com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava'
// Play Core
implementation 'com.google.android.play:core:1.8.0'
implementation 'com.google.android.play:core-ktx:1.8.1'
All proprietary, and thus show-stoppers.
TL;DR: A listing at "F-Droid proper" isn't that easily achieved here, and would need quite some work. Not sure if @b-lam is willing to do that (can be done via build flavors as long as the core functionality of the app doesn't depend upon one of those).
from resplash.
@IzzySoft Thanks for the write-up! Removing these shouldn't affect the core functionality but unfortunately I don't really have the time or resources to support both versions right now. @LongJohn-Silver All the code is open source so you could fork this project and make it your own or submit a PR if this is something you really want.
I am just learning to code on Python, so I don't think I can help here. But if I ever do, I'll be glad.
from resplash.
Also pinning said issue would create more attention.
from resplash.
Related Issues (20)
- [Feature Request] Add multiple sources to Auto Wallpaper HOT 4
- Resplash auto wallpaper related problem. HOT 3
- [Feature Request] dark overlay for wallpapers HOT 1
- Samsung fold4 issue
- [Feature Request] Personal sources other than Unsplash HOT 1
- [Feature Request] Account Backup HOT 3
- [Feature Request] set an exact time for auto change HOT 1
- Auto doesn't apply wallpaper to Lock screen in "Home screen & lock screen" HOT 7
- Auto wallpaper not working
- Stop repeating the same pictures when there are new ones to show HOT 3
- Is this to be implemented? Was looking for the exact same thing. I can of course wait until the specific time to change it and then set the duration to 24 hrs but if for example I change the choice of the wallpaper, it seems to reset the timer.
- Could you share the location of the Cache Files? HOT 2
- Notifications are not working HOT 3
- [Pro] Getting pro without Google play HOT 1
- A better widget design
- Can't download photos with its metadata.
- [Feature Request] Force Random Wallpaper Change
- Can't add Collections
- Unsplah + Collection HOT 2
- Add Blacklist tags for auto wallpaper
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from resplash.