Code Monkey home page Code Monkey logo

Comments (12)

jmd9019 avatar jmd9019 commented on July 30, 2024 10

Getting same problem

Adding version solved it

      - name: Helm installer
        uses: Azure/setup-helm@v3
        with:
          version: 'v3.10.1'

from setup-helm.

ethan-k avatar ethan-k commented on July 30, 2024 3

Faced the same issue but replaced azure/setup-helm with the below code for now

      - name: Install Helm
        run: |
          curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash

from setup-helm.

OliverMKing avatar OliverMKing commented on July 30, 2024 3

This has been fixed and released in v3.4 (and v3). Please upgrade to one of these versions. Thanks!

from setup-helm.

OliverMKing avatar OliverMKing commented on July 30, 2024 2

#100 will be merged in and released shortly. That fixes this issue. Thanks everyone for the help!

from setup-helm.

vdhpieter avatar vdhpieter commented on July 30, 2024 1

They relied on the default ordering of the GH GQL api and that probably got changed...

Changing the query used here and loosing the reverse (why do that if the API can do it for you?):

setup-helm/src/run.ts

Lines 58 to 73 in b70d33f

const {repository} = await graphqlAuthenticated(
`
{
repository(name: "helm", owner: "helm") {
releases(last: 100) {
nodes {
tagName
}
}
}
}
`
)
const releases: string[] = repository.releases.nodes
.reverse()
.map((node: {tagName: string}) => node.tagName)

query {      
  repository(name: "helm", owner: "helm") {
    releases(first: 10, orderBy: {field: CREATED_AT, direction: DESC}) {
      nodes {
        tagName
      }
    }
  }
}

Maybe I find time to PR this, but if somebody wants to do it be my guest!

from setup-helm.

marcindabrowski avatar marcindabrowski commented on July 30, 2024 1

But even when an order is added some computation of the latest need to be done. The latest could be some patch for previous major/minor.

from setup-helm.

sverweij avatar sverweij commented on July 30, 2024 1

@marcindabrowski / @vdhpieter we might want to use the isLatest attribute from the GitHub API for this. See - graphql/reference/objects#release.

So a slight modification to @vdhpieter 's query ...

query {
  repository(name: "helm", owner: "helm") {
    releases(first: 10, orderBy: {field: CREATED_AT, direction: DESC}) {
      nodes {
        tagName
        isLatest
        isDraft
        isPrerelease
      }
    }
  }
}

... and then adapting the processing (ref: src/run.ts#L71-L75 might do the trick:

      // ...
      const latestValidRelease: string = repository.releases.nodes
         .find(
            ({tagName, isLatest, isDraft, isPreRelease}) => 
                isValidVersion(tagName) && isLatest && !isDraft && !isPreRelease
          )?.tagName

      if (latestValidRelease) return latestValidRelease
      // ...

Related: recent announcement that the meaning of the isLatest attribute has changed a bit since it was introduced.

Edit: PR #100 seems to fix this issue (even without the above suggestions). I've taken the liberty to leave above suggestions as review comments hoping I didn't violate any community conventions ...

from setup-helm.

uchinda-sph avatar uchinda-sph commented on July 30, 2024

facing the same issue

from setup-helm.

dotrieutan avatar dotrieutan commented on July 30, 2024

got same problem, the download link was updated or something ?

from setup-helm.

ImRodry avatar ImRodry commented on July 30, 2024

The linked PR was merged but this still isn’t resolved, are we waiting for anything else?

from setup-helm.

vdhpieter avatar vdhpieter commented on July 30, 2024

@ImRodry the PR (#100) is not yet merged

from setup-helm.

ImRodry avatar ImRodry commented on July 30, 2024

Ah ok was looking at clusterpedia-io/clusterpedia-helm#15
Do you have an ETA for when that will be merged?

from setup-helm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.