Comments (7)
For clarity step 3, the load testing step, should only occur on demand or during preparation of a release. This is an expensive and time consuming set of tests.
from moodle.
Rephrased this issue title for v1.5.1, where we focus on no. 2 of this issue (1 is done now). 3 (load testing running) is not scoped in here.
from moodle.
FYI, all the necessary information for testing the deployed site is available from az group deployment show -g $AZURE_RESOURCE_GROUP -n azuredeploy --query properties.outputs
. You can add the next-level field name in the --query properties.outputs
to get a specific output, or simply use jq
to extract needed information from the JSON output.
from moodle.
Hi @hosungsmsft -- I've noticed you added "CI only master branch". Is there a reason behind that?
I think it would be nice to have it for all branches. It is common, for example, to create a feature branch and do all dev work on that before merging back into master, and it would be nice to have the CI running on those branches too.
See: dcceea9#diff-354f30a63fb0907d4ad57269548329e3R4
What do you think?
Cheers
from moodle.
@roperto -- Thanks for your question. My reasoning behind that restriction was that the full CI that includes the test deployment might be unnecessarily costly for non-master branches (time-wise and Azure cost-wise). I'd be totally fine if the linting part of the CI is run on every branch, and I suppose that can be programmatically controlled using some env var? What do you think? Thanks!
from moodle.
@hosungsmsft -- That is a good point, I created #90 to separate it from this thread and I will continue working on this issue. Thank you for the feedback.
from moodle.
Fixed in #91
from moodle.
Related Issues (20)
- Url domain HOT 1
- Amazing - Job well done. HOT 1
- URGENT - The Large Size ARM template pointing this repo doesn't deploy.... HOT 2
- The Large templates deploys MySQL 5.6.47.0 but the template claims it's 5.7 HOT 3
- concurrent users on moodle HOT 4
- Moodle 4.1 HOT 10
- Failed to install Azure CLI on the Load Test VM
- Failed to install jmeter
- Your deployment failed HOT 18
- Moodle on AKS slow with Azure File and no file when using Azure blob HOT 4
- Your deployment failed HOT 2
- After Migrate Existing Moodle in this template site response very slow
- Mount failed When choose fileserver type Gluster HOT 5
- Deployment template validation failed: 'The template parameters 'osDiskSizeInGB' in the parameters file are not valid; HOT 1
- Creation of instances failed HOT 2
- feature request - azure WAF and/or azure frontdoor HOT 1
- feature request - moodle deployment with HA/DR on pair region
- Deployment failure for Moodle 4.1 and PHP 7.4 template Large-ha HOT 2
- Moodle on Azure App Service
- Resource Failed deployment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moodle.