Comments (9)
Oops. I know what the problem is, I forgot that we need to publish the new JSON lib.
from diagnostics-eventflow.
Hmm, not sure... at this point I am inclined to try the simplest thing that will fix this and a separate NuGet package is just that.
from diagnostics-eventflow.
It tends to be a bad idea to pack dlls for dependencies directly into packages anyway because if multiple packages contain the same dll it can lead to problems.
from diagnostics-eventflow.
@ghelyar The Json package should be accessible from NuGet now. LMK please if this solves the problem, or if there are any issues still.
from diagnostics-eventflow.
Would it be better if this dep Microsoft.Diagnostics.EventFlow.Json is internal assembly dependency rather than creating a new nuget package with the required versioning?
from diagnostics-eventflow.
This seems similar:
https://stackoverflow.com/questions/59611527/how-to-pack-a-referenced-project-into-a-nuget-package
The second answer based on custom target in Directory.Build.targets looks promising, although with lower score.
from diagnostics-eventflow.
Keep open till NuGet is updated
from diagnostics-eventflow.
This seems to work now, thank you.
from diagnostics-eventflow.
Fantastic, thanks for confirmation
from diagnostics-eventflow.
Related Issues (20)
- Request ability to use ConnectionString in ApplicationInsightsOutputConfiguration HOT 2
- In metric, Unable to cast object of type Int32 to type Double HOT 12
- EventFlow not working with .NET 5 HOT 3
- Upgrade Microsoft.ApplicationInsights dependencies HOT 1
- Duplicate dependencies in elastic search output HOT 3
- Update Nuget authoring when PR 387 is merged HOT 3
- .NET 4.6.1 implementation of Core assembly does not use precise clock
- Need to set proxy for ElasticSearch output HOT 6
- Shall we remove unused `Microsoft.Diagnostics.EventFlow.TableStorage`? HOT 1
- Update test platform matrix HOT 1
- Remove Nuget binary from sources HOT 1
- This repo is missing important files
- Does EventFlow supports for app in Azure Kubernetes Service? HOT 1
- Guidance when to use EventFlow? HOT 3
- Service Fabric Support - Load App Insights connection string from environment variable HOT 5
- Add ability to configure index format string HOT 2
- CsvHealthReporter does not output any logs HOT 1
- EventSourceInput captures System.Runtime logs as well (NET 7) HOT 12
- Superfluous dependencies to nuget packages
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diagnostics-eventflow.