Table name validation throws even if callback is supplied about azure-storage-node HOT 4 CLOSED

All the errors that happen after we make the service call to the storage service are returned in the callback. The errors that happen before(mainly argument, invalid operation issues) are thrown.

We are fine with exposing the validation-utilities. But can you please tell us how you would avoid the exception if we exposed the validation methods?

from azure-storage-node.

I have a module that has azure-storage-node as a dependency and the table name is set programmatically. In version 0.2.0 the validation utilities was exposed and I used it similar to this:

var AzureStorage = require('azure-storage');

function callback(e) {
    if (!!e) {
        return console.log('error', e.message);
    }
    console.log('success');
}

var tableName = 'cache-me';

var tableService = AzureStorage.createTableService('UseDevelopmentStorage=true;DevelopmentStorageProxyUri=http://127.0.0.1;');

AzureStorage.Validate.tableNameIsValid(tableName, function (verr) {
    if (verr) {
        return callback(verr);
    }

    tableService.createTableIfNotExists(tableName, function (err) {
        callback(err);
    });
});

In the current version I would be forced to implement it like this:

try {
    tableService.createTableIfNotExists('in-valid', function (err) {
        callback(err);
    });
} catch (verr) {
    callback(verr);
}

that, imho, kind of breaks the asynchronous pattern of node.

On the wish list it would be great if the validation returned the error in the callback. I would make a proper PR but I'm out of office and have a hard time to get the CLA signed by my employer.

from azure-storage-node.

Thank you for the detailed explanation. As I mentioned before, all the errors that happen after we make the service call to the storage service are returned in the callback. The errors that happen before(mainly argument, invalid operation issues) are thrown. This is in line with the documentation here - https://www.joyent.com/developers/node/design/errors.

We are however going to expose the validation utils in an upcoming release so you can continue using your code. Thanks!

from azure-storage-node.

We have fixed this in our latest release (0.3.1). Please upgrade to the latest.

from azure-storage-node.