Code Monkey home page Code Monkey logo

Comments (5)

mayankagg9722 avatar mayankagg9722 commented on August 17, 2024

@theunrepentantgeek @super-harsh Please help me to debug this further.

from azure-service-operator.

matthchr avatar matthchr commented on August 17, 2024

We'll take a look at this

from azure-service-operator.

mayankagg9722 avatar mayankagg9722 commented on August 17, 2024

I have discussed this with @super-harsh and he figured out that this commit by him caused this breaking change:
https://github.com/Azure/azure-service-operator/pull/3953/files.

We need to revert this checkin.

from azure-service-operator.

matthchr avatar matthchr commented on August 17, 2024

It sounds like @super-harsh and @mayankagg9722 synced up and figured out what the issue was, and Mayank will send a PR to help resolve it.

from azure-service-operator.

theunrepentantgeek avatar theunrepentantgeek commented on August 17, 2024

We need to revert this checkin.

It's not as simple at this. We need to fix the regression, while keeping the quality-of-life improvements @super-harsh brought in. We also need to ascertain why the existing test suite didn't catch this problem.

from azure-service-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.