[FEATURE REQ] Encode invalid URL character, even when encoded=true on PathParam or QueryParam about azure-sdk-for-java HOT 2 OPEN

Thanks for reporting this ask Weidong.

I'm actually going to push back against this request from the Core perspective as in this case the path and query parameter annotations state the passed value is already encoded. Which if we try to encode again, we may run into double encoding issues which are just as nebulous, if not worse because they'll always be valid but would result in possible corruption / requests that aren't doing what is expected.

Or to state it more bluntly, I'd rather throw a very explicit error than try to work and maybe work correctly. But, I'd be happy to add in utility methods that could be called to handle these scenarios.

from azure-sdk-for-java.

Sure, we probably keep the issue for some time for more discussion.

Here the ask is only encode invalid character that never could happen to URL (it is hard for me to find the full list of such characters explicitly, but I guess "space" is one of them). So e.g. %20 won't be encoded again.

I am OK if we decide to do the encoding either in emitted code directly, or via calling a helper method.

One argument for doing this in core, is that if the completed URL (pieced together from RestProxy) have invalid character, the request guaranteed to fail. And some 3rd-party http client (e.g. Python's) does "fix" these invalid character.
Of course, the alternative of "throw an Error" or "let the underlying Http Client handle it" also make sense.

from azure-sdk-for-java.