Comments (2)
Thanks for reporting this ask Weidong.
I'm actually going to push back against this request from the Core perspective as in this case the path and query parameter annotations state the passed value is already encoded. Which if we try to encode again, we may run into double encoding issues which are just as nebulous, if not worse because they'll always be valid but would result in possible corruption / requests that aren't doing what is expected.
Or to state it more bluntly, I'd rather throw a very explicit error than try to work and maybe work correctly. But, I'd be happy to add in utility methods that could be called to handle these scenarios.
from azure-sdk-for-java.
Sure, we probably keep the issue for some time for more discussion.
Here the ask is only encode invalid character that never could happen to URL (it is hard for me to find the full list of such characters explicitly, but I guess "space" is one of them). So e.g. %20
won't be encoded again.
I am OK if we decide to do the encoding either in emitted code directly, or via calling a helper method.
One argument for doing this in core, is that if the completed URL (pieced together from RestProxy) have invalid character, the request guaranteed to fail. And some 3rd-party http client (e.g. Python's) does "fix" these invalid character.
Of course, the alternative of "throw an Error" or "let the underlying Http Client handle it" also make sense.
from azure-sdk-for-java.
Related Issues (20)
- [BUG] Enabling logging triggers fatal error under security manager HOT 1
- [FEATURE REQ] Create a `ResourceIdentifier` type in azure-core HOT 1
- CosmosDB - The request did not complete due to a high rate of metadata requests HOT 5
- OTel metrics: support specifying histogram boundaries
- Unexpected deployment status on Azure WebApp Slot using getDeploymentStatusAsync from SupportsOneDeploy HOT 3
- OTel tracing: add option to provide lib-specific schema URL
- [BUG] azure-messaging-servicebus:7.15.1 - Application not consume any message from Azure Service Bus after logs "The connection was closed by container because it did not have any active links in the past 300000 milliseconds" printed on AKS HOT 8
- [FEATURE REQ] Missing "additional-spring-configuration-metadata.json" in artifact spring-cloud-azure-starter-appconfiguration-config HOT 4
- Regenerate Azure AI Search with latest Swagger
- Create/Investigate Azure Toolkit Credential
- [BUG] invalid wasb credentials taking 13-14 minutes to execute HOT 2
- [BUG] investigate live test failures
- [FEATURE REQ] Change OpenAIAsyncClient to be compatible with other Open AI compatible GPTs such as Ollama
- Check for new classes to be added to native-image.properties from 3p libraries.
- [BUG] Cannot provision VMs with Ultra SSD disk HOT 3
- [BUG] EventProcessorClient sometimes stops reading in low traffic environments
- [BUG] Typo in doc for azure-cosmos-spark: ServicePrinciple not ServicePrincipal HOT 3
- [FEATURE REQ] Extend AAD support to azure-cosmos-spark throughput control HOT 2
- [QUERY] Confirm behavior of Azure-AsyncOperation for PATCH/PUT with final-state-via set
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-sdk-for-java.