Code Monkey home page Code Monkey logo

Comments (13)

ahmetb avatar ahmetb commented on July 17, 2024

@tianon yeah we started to break things massively after those tags. The docker-machine and docker-registry repos vendor one of those tags.

We'll be doing some 2.0 soon, please read my comment here for the current status: #183 (comment)

from azure-sdk-for-go.

tianon avatar tianon commented on July 17, 2024

Heh, docker-registry is actually the very reason I'm here -- they currently pull in 97d9593, which comes after v1.2 (https://github.com/docker/distribution/blob/7a305cc8cdf1427455fc7021e51629498332c965/Godeps/Godeps.json#L20-L23).

from azure-sdk-for-go.

tianon avatar tianon commented on July 17, 2024

So do you want to keep this issue open as a clear pointer for folks looking for newer tag, or just close it? I don't mind either way. 👍

from azure-sdk-for-go.

ahmetb avatar ahmetb commented on July 17, 2024

Heh I just remembered that we had to take a hotfix due to a memory leak in the Blob Storage SDK. Are you having any issues with the vendored code in docker-registry right now?

Let's keep it open as a work item. Thanks for bringing this up.

from azure-sdk-for-go.

tianon avatar tianon commented on July 17, 2024

Naw, I'm actually working on some Debian packaging, and was trying to figure out what to package. From our conversation here, I think I'll just package a snapshot instead of 1.2 for now until 2.0 drops. 👍

from azure-sdk-for-go.

ahmetb avatar ahmetb commented on July 17, 2024

@tianon if you're packaging docker registry, you should probably keep the same vendored commit number?

from azure-sdk-for-go.

tianon avatar tianon commented on July 17, 2024

We only get one commit/snapshot for the whole of the Debian archive (regardless of which packages build-depend on it), which is why I was hoping for something more "sanctioned" than some random commit somewhere. 😄

from azure-sdk-for-go.

tianon avatar tianon commented on July 17, 2024

(So if that commit is pretty "decent", why not tag it as v1.3 in the interim?)

from azure-sdk-for-go.

tianon avatar tianon commented on July 17, 2024

FWIW, docker-machine is using 515f3ec, which isn't even quite v1.2 (https://github.com/docker/machine/blob/08208bd1415f26e5bc2e5339f002fb7954b70e50/Godeps/Godeps.json#L10-L14)

from azure-sdk-for-go.

ahmetb avatar ahmetb commented on July 17, 2024

We can do that but it doesn't help much other than docker-registry, which also works with the commit number for now. When we tag v2.0, I'll be bumping that as well.

The case with docker-machine is, it nearly predates all the code that's currently in this repo. We basically rewrote all that. Historically, this SDK was created just for docker-machine, and it was pretty hacky.

At some point in the future, I'll be bumping vendored versions in both and fix breaking changes.

from azure-sdk-for-go.

dhilton avatar dhilton commented on July 17, 2024

Is there a feel for when v2.0 might drop? Before christmas? Just trying to get a feel for when it's worth revisiting #183 and the cascade of features to Terraform and others upstream.

from azure-sdk-for-go.

brendandixon avatar brendandixon commented on July 17, 2024

@dhilton The ARM portion of the SDK is bounded by how fast we can get good specs into the https://github.com/Azure/azure-rest-api-specs repository. We had a good start, but they've dragged a bit lately. We're looking into what's holding things up.

from azure-sdk-for-go.

ahmetb avatar ahmetb commented on July 17, 2024

We have tags now. Closing.

from azure-sdk-for-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.