Creating a VM from a VM image fails with "In order to use extension reference, ProvisionGuestAgent must be set during virtual machine provisioning." about azure-sdk-for-go HOT 9 CLOSED

This may be because of the empty ResourceExtensionReferences element, I'll investigate...

from azure-sdk-for-go.

Yep... if I rename the XML element the test succeeds... This was introduced by https://github.com/Azure/azure-sdk-for-go/pull/120/files#diff-1fa4f35573c334c3564b4beebfd085eeL228

I'll see if I can fix it without introducing pointers... :-) @svanharmelen @ahmetalpbalkan

from azure-sdk-for-go.

@paulmey hmm... Nasty... So maybe we need a custom xml marshal func after all.

from azure-sdk-for-go.

That, or maybe just a second level there...
It's either that or a pointer. I can't get a custom marshaller for just wrapped collections to work...

from azure-sdk-for-go.

@svanharmelen in this particular case, I think it makes sense to distinguish between an empty array of 'resource extension references' and no array at all (nil). Especially in the case of an 'Update Role' operation.
An empty array means that you want to remove all extensions, whereas no array (nil) means that you do not wish to update this aspect of the Role.
Let me test out with some integration tests whether this is the way it works...

from azure-sdk-for-go.

After doing some hands on tests (paulmey/azure-sdk-for-go@c7b4d1d), it appears that for UpdateRole, nil and empty array are semantically equivalent (ie. I was wrong above). Extensions are deleted by updating the status to uninstall.

from azure-sdk-for-go.

@paulmey wow interesting.

from azure-sdk-for-go.

well... that's an upbeat reaction... 😉

from azure-sdk-for-go.

fixed by #165

from azure-sdk-for-go.