Method UploadToBlobAsync on DeviceClient throws exception if DeviceId contain special characters about azure-iot-sdk-csharp HOT 6 CLOSED

Investigating !

from azure-iot-sdk-csharp.

Hi @bartoszbr 
Can you please confirm that you were successful using a device ID that doesn't contain any special character? I am asking because this shouldn't be a problem.
Another thing: are you using the received URI immediately? By default the TTL for the storage URI SAS is 1hour.
Can you share the piece of code you are using?

from azure-iot-sdk-csharp.

Yes I can send files to another devices where DeviceId doesn't have any special character. I checked it also on another Azure account with another subscription and there was the same.
In every cases I use standard, default Azure Storage - I just connected it with my IoT Hub.

Initialization of DeviceClient object:
deviceClient = DeviceClient.Create(iotHubUri, new DeviceAuthenticationWithRegistrySymmetricKey(deviceName, deviceKey));

Method to handle Click event and call UploadToBlobAsync:

  private async void sendFileButton_Click(object sender, EventArgs e)
        {
            if (ControlsHelper.IsComboBoxSelected(deviceIdComboBox, "Device ID") == false)
                return;

            var openFileDialog = new OpenFileDialog();
            var result = openFileDialog.ShowDialog();

            if (result != DialogResult.OK)
                return;

            using (var fileStream = openFileDialog.OpenFile())
            {
                var watch = System.Diagnostics.Stopwatch.StartNew();
                try
                {
                    await deviceClient.UploadToBlobAsync(openFileDialog.SafeFileName, fileStream);
                }
                catch (Exception ex)
                {
                    LogError("Exception occurred during sending file", ex);
                    watch.Stop();
                    return;
                }

                watch.Stop();
                var text = $"DeviceID: {deviceIdComboBox.SelectedItem} File {openFileDialog.SafeFileName} was sent in {watch.ElapsedMilliseconds}ms";
                LogInformation(text, sentMessagesRrichTextBox);
            }
        }

from azure-iot-sdk-csharp.

Hi @bartoszbr
I was able to locally reproduce the issue using # symbol in device ID . The issue is specific to C# client SDK and doesn't happen with C Azure IoT SDK.

The issue happens when following call is made
https://github.com/Azure/azure-iot-sdk-csharp/blob/master/device/Microsoft.Azure.Devices.Client/Transport/HttpTransportHandler.cs#L230
When CloudBlockBlob object is created it omits special character # in StorageURI along with string after it. That is why UploadFromStreamAsync call fails.

Further investigation is going on to resolve this.

from azure-iot-sdk-csharp.

Hi @bartoszbr
Fix for this issue has been merged 2366f03 into master

from azure-iot-sdk-csharp.

This is now in the latest release. Closing.

from azure-iot-sdk-csharp.