Flake: TestRefreshingCertificate panics about aro-rp HOT 6 CLOSED

For visibiltiy: had a chat with @petrkotas. This looks like a different sympthom of the issue which is being fixed in #1636.

from aro-rp.

@petrkotas I think there's still a flake here. On unit test run of #1645 it failed the first time which had your changes from #1636. I reran and it worked successfully. Tried to reproduce locally but I couldn't.

Look at build run 1 (number 2 passed successfully) here. You might have to click "Show Previous Attempts".

=== FAIL: pkg/env TestRefreshingCertificate/test_refresh_certificate,_pull_exactly_twice,_first_on_start,_second_on_refresh (0.06s)
    certificateRefresher_test.go:272: returned private key does not match
    certificateRefresher_test.go:276: returned certificate does not match
    --- FAIL: TestRefreshingCertificate/test_refresh_certificate,_pull_exactly_twice,_first_on_start,_second_on_refresh (0.06s)

from aro-rp.

We are currently using time to do these tests. Maybe we could use clockwork or something that mocks time to get from what seems to be a race.

from aro-rp.

FWIW: I ran into this a few times recently in PR's, so attempted to recreate it locally. I ran the unit tests for over 2 hours non-stop with 130 different attempts without failure. This makes me more suspicious of the azure environment since I could not reproduce locally, but will continue to attempt to do so.

from aro-rp.

Nevermind, as I posted this I was able to get the error locally. Good news.

from aro-rp.

I think #1691 fixes it. I just merged it.

@bryanro92 @troy0820 @bennerv could you please update and check?

I was checking with this:

while; do go clean -testcache && go test -timeout 30s -run ^TestRefreshingCertificate$ github.com/Azure/ARO-RP/pkg/env; done

Please reopen if this still happens.

from aro-rp.