ACR tasks managed identity token format inconsistent about acr HOT 4 CLOSED

The values can be number or string. If you check the official adal go library, you can see how they parse the payload

https://github.com/Azure/go-autorest/blob/d3f8f8a6cdf252e58b19b99523c25c5ad6664ac7/autorest/adal/token.go#L1139

from acr.

Hi @northtyphoon,

According to documentation https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=windows#schema:

In json responses, all primitives will be of type string, and missing or inapplicable values are always included but will be set to an empty string.

From the client's point of view, all Managed Identity endpoints (http://169.254.169.254/metadata/identity/oauth2/token) are the same service, no matter if called from a VM, Container Instance, or Container Registry Task. So it would be logical to return data in the same format. Which is actually also documented here:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2021-12-13/imds.json

from acr.

@andreygoran we have deployed a fix to change the property to string. Can you try it again?

from acr.

@andreygoran we have deployed a fix to change the property to string. Can you try it again?

I tested it, and it is fixed now. Thank you!

from acr.