Code Monkey home page Code Monkey logo

Comments (9)

github-actions avatar github-actions commented on July 18, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from acr.

antsok avatar antsok commented on July 18, 2024

Is this repo being watched by the ACR team?

from acr.

northtyphoon avatar northtyphoon commented on July 18, 2024

You already specify agentPoolName to defaultPool when you create task resource. You don't need to pass it again in acrTaskRun request as the error pointed it out.

You can try remove agentPoolName from acrTaskRun and see if it works.

resource acrTaskRun 'Microsoft.ContainerRegistry/registries/taskRuns@2019-06-01-preview' = if(doTaskRun) {
  name: name
  parent: acr
  location: location
  properties: {
    forceUpdateTag: forceUpdateTag
    runRequest:{
      isArchiveEnabled: true
      type: 'TaskRunRequest'
      taskId: acrTask.id
    }
  }
}

from acr.

yuehaoliang avatar yuehaoliang commented on July 18, 2024

The agent pool configuration is defined at the task level, and once a task has been designated to run on a specific agent pool, it should not be re-specified for individual task runs.

@antsok I've noticed you mentioned "However when taskrun is executing it is not using the custom agent pool defined for task". Are you certain about that? To verify, you can use the "az acr task show-run" command and examine whether the agent pool name for the task run is null. Additionally, providing us with the registry name and task run ID will enable us to investigate whether the task run indeed executed on your designated custom agent pool.

from acr.

antsok avatar antsok commented on July 18, 2024

The agent pool configuration is defined at the task level, and once a task has been designated to run on a specific agent pool, it should not be re-specified for individual task runs.

This explanation needs to find its way in removing the agentPool property from the taskRun resource

@antsok I've noticed you mentioned "However when taskrun is executing it is not using the custom agent pool defined for task". Are you certain about that? To verify, you can use the "az acr task show-run" command and examine whether the agent pool name for the task run is null. Additionally, providing us with the registry name and task run ID will enable us to investigate whether the task run indeed executed on your designated custom agent pool.

The problem was reported 6 months ago. I no loger have those resources deployed, and logs are not retained for that long.

from acr.

yuehaoliang avatar yuehaoliang commented on July 18, 2024

This explanation needs to find its way in removing the agentPool property from the taskRun resource

For a quick Run (without the creation of a Task resource), the agentPoolName property is necessary to specify where it should be run.

Likewise, when using Azure CLI, you can request a quick Run on an Agentpool by "az acr build --agent-pool", or you can create a Task configured with an Agentpool by "az acr task create --agent-pool" and subsequently execute this Task by "az acr task run". However, "az acr task run --agent-pool" will result in an error "You cannot set the agent pool name in the task run request. Please set the name on the task".

I understand your point, and I agree that the Bicep templates can be misleading. It should be documented that if the Agentpool is configured for a Task resource, the agentPoolName property should be removed for a Run resource. Thank you for your suggestion; we will assess how to enhance the user experience in this regard.

from acr.

antsok avatar antsok commented on July 18, 2024

Thank you for agreeing to consider updating the documentation. It would help avoid the confusion indeed.

from acr.

github-actions avatar github-actions commented on July 18, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

from acr.

github-actions avatar github-actions commented on July 18, 2024

This issue was closed because it has been stalled for 30 days with no activity.

from acr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.