[Chore] CICD versus local dev for post-create-command about contoso-real-estate HOT 5 CLOSED

This means that we are calling npx playwright somewhere. Is this the recommended approach?

from contoso-real-estate.

Looks like passing --yes to nox would help here: https://docs.npmjs.com/cli/v8/commands/npx#description

from contoso-real-estate.

I forked the project and tried to open main using codespaces and end up in the same place @dfberry mentioned. Ctrl-shift-p to Codespaces: View Creation Log shows the following spew (just the tail). It looks like things are stuck on a, "Ok to proceed?" prompt and there's no way for me to respond.

...
65 packages can be upgraded. Run 'apt list --upgradable' to see them.
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Not compatible with your version of node/npm: [email protected]
npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
npm ERR! notsup Actual: {"npm":"9.5.0","node":"v18.15.0"}

npm ERR! A complete log of this run can be found in:
npm ERR! /home/node/.npm/_logs/2024-02-06T21_23_34_708Z-debug-0.log
Need to install the following packages:
[email protected]
Ok to proceed? (y)

from contoso-real-estate.

Hi @jeffvan98 would mind editing your /.devcontainer/post-create-command.sh and let me know if that helps.

You can change this line:

npx playwright install --with-deps

to this:

npx --yes playwright install --with-deps

Note the --yes right after npx. You will also need to rebuild your devcontainer.

from contoso-real-estate.

Fixed in #437

from contoso-real-estate.