Static timeout values in Conn about websockex HOT 6 CLOSED

There's no reason I can think of that they couldn't be. Feel like opening a PR?

from websockex.

I am feeling it 💃

from websockex.

@Azolo Might you have a look at commit ddc50b4 before PR?

from websockex.

It looks good, I left a couple of comments.

But I think I prefer the Conn struct flat for the sake of discoverability. Someone can open up IEx and do something like:

iex> struct(WebSockex.Conn)
%WebSockex.Conn{cacerts: nil, conn_mod: nil, extra_headers: [], host: nil,
 insecure: true, path: nil, port: nil, query: nil, socket: nil, transport: nil,
 socket_connect_timeout: 6000, socket_recv_timeout: 5000}

But functionality wise, it looks spot on.

from websockex.

Thanks for your feedback, i updated the implementation.

from websockex.

Closed by #15

from websockex.