Code Monkey home page Code Monkey logo

Comments (4)

Azgaar avatar Azgaar commented on July 19, 2024 1

Hello and thanks for the suggestion. I would say that it's pretty easy to implement. I also plan to add an ability to generate similar-looking coas in gallery. So see a lot of variants on the same screen and to be able to select from.

from armoria.

Azgaar avatar Azgaar commented on July 19, 2024 1

Some refactoring is indeed required, so it would be nice to split in into independent functions.

from armoria.

Azgaar avatar Azgaar commented on July 19, 2024 1

The refactoring PR is merged now

from armoria.

latiif avatar latiif commented on July 19, 2024

It's been really fun working on the codebase.

Since I'm working on randomizing components (charges and ordinaries), I thought I could take a look and maybe reuse the code in src/scripts/generator.js, which seems to export only two functions.

I have to ask if you have re-factoring src/scripts/generator.js on the roadmap, because it can use some love.
There are a couple of functions defined within generate that I would love to reuse for this issue, but simply taking them out was not a option due to the deep inter-dependencies between them.

What do you suggest? Take the time to refactor generate() and the entire src/scripts/generator.js file? or just find away around it?
I'm asking because I intend to keep my PR small and change as few files as possible.

from armoria.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.