Comments (4)
Hello and thanks for the suggestion. I would say that it's pretty easy to implement. I also plan to add an ability to generate similar-looking coas in gallery. So see a lot of variants on the same screen and to be able to select from.
from armoria.
Some refactoring is indeed required, so it would be nice to split in into independent functions.
from armoria.
The refactoring PR is merged now
from armoria.
It's been really fun working on the codebase.
Since I'm working on randomizing components (charges and ordinaries), I thought I could take a look and maybe reuse the code in src/scripts/generator.js
, which seems to export only two functions.
I have to ask if you have re-factoring src/scripts/generator.js
on the roadmap, because it can use some love.
There are a couple of functions defined within generate
that I would love to reuse for this issue, but simply taking them out was not a option due to the deep inter-dependencies between them.
What do you suggest? Take the time to refactor generate()
and the entire src/scripts/generator.js
file? or just find away around it?
I'm asking because I intend to keep my PR small and change as few files as possible.
from armoria.
Related Issues (20)
- Issues with some of the new charges HOT 4
- pretiffy svg markup
- Make downloaded svg compatible with Inkscape
- Blurry renderings HOT 5
- Saving an SVG without a gradient produces a black appearance HOT 6
- Sails shield shape
- License links are open in the same tab HOT 1
- Navbar menu is getting hidden on hover HOT 1
- Support i18n on code level
- Translate app into Russian
- Change tincture color from editor HOT 1
- Add a text box showing the symbolism and history of a selected charge HOT 3
- Use the Github integration feature of Crowdin to allow offline use? HOT 7
- Combine charges HOT 2
- Simplified charges upload for well-known icon collections
- Add text elements HOT 1
- Semy HOT 3
- Color group can have 0 total chance HOT 1
- Scale issue HOT 2
- Sizing Issue HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from armoria.