Blockedges are not being set to unavailable after submitting a survey about nyc-trees HOT 3 CLOSED

The surveys listed in the attached spreadsheet back to May 2015, so we can be fairly confident that whatever is going on is not related to recent changes in the application.

There is only once place in the code where new surveys are created, and if the mapper reaches the final preview page with the “Does this look right?” message then the survey must have been saved and the is_available field on the associated block edge must have been set to False.

If the mapper taps “No, Restart” from the final preview, and then taps “Restart” (or possibly double-taps on “No, Restart”) then the application, by design, updates the blockface record to set is_available back to True.

from nyc-trees.

Do we have any information on when the blockface is flipping back to available? Do we know if it is immediately after the survey is submitted, or sometime later?

It’s immediate, or put another way, the problem is that the blocks are never flipping to not available, so immediately after someone completes a survey they look at the map and the block they just did is still open.

It is “good” that it is happening immediately. That behavior matches the way the code is structured.

• The Mapper submits a survey
• The App saves a new survey row to the database and sets is_available on the blockface to False within the same database transaction.
• The App shows the output of the geometry constructor and presents 3 options
  • If the Mapper taps “Yes,” the App just redirects to the survey page.
  • If the Mapper taps “No, Restart” and then taps “Restart” (or possibly double-taps “No, Restart” since the buttons are in the same location and the associated text box does not require content) the App updates the blockface to set is_available back to True and redirects to the survey page.
  • If the Mapper taps “No, Submit for Review” then enters a message and taps “Submit for Review” the App updates the survey to set is_flagged to True and leaves is_available set to False on the blockface.
    If “No, Restart” is tapped by mistake, there is no way to go back and choose another option. The Mapper has to tap “Restart” to get back to the survey page, which sets is_available on the blockface back to True.

from nyc-trees.

Closing for now because:

• It cannot be reliably recreated in staging.
• The problem is not a recent regression
• Code auditing shows that block availability is only changed in 2 places, to False when a survey is submitted and to True when a survey is restarted.

If we want to dig into this further, we could make it required for users to complete the "why do you want to restart" box that appears after clicking "no, restart." That would likely serve as a check when people hit the restart button accidentally and potentially reduce the number of unintended multiple surveys.

from nyc-trees.