Comments (5)
@vkurchatkin Would you mind providing example code so that I know how to reproduce this?
from axios.
Here it is
var axios = require('axios');
var http = require('http');
var assert = require('assert');
var str = Array(100000).join('ΠΆ');
http.createServer(function(req, res) {
res.setHeader('Content-Type', 'text/html; charset=UTF-8');
res.end(str);
}).listen(4444, function() {
axios.get('http://localhost:4444/').then(function(response) {
process.nextTick(function() {
assert(response.data === str);
});
});
});
I'm not sure that this test is 100% reliable (or that a 100% reliable test of this exists at all)
from axios.
Thanks. I'll give this a look.
from axios.
Here is a quick fix:
diff --git a/lib/adapters/http.js b/lib/adapters/http.js
index 8a6fbf6..81da7ac 100644
--- a/lib/adapters/http.js
+++ b/lib/adapters/http.js
@@ -52,15 +52,15 @@ module.exports = function httpAdapter(resolve, reject, config) {
// Create the request
var transport = parsed.protocol === 'https:' ? https : http;
var req = transport.request(options, function (res) {
- var responseText = '';
+ var responseBuffer = [];
res.on('data', function (chunk) {
- responseText += chunk;
+ responseBuffer.push(chunk);
});
res.on('end', function () {
var response = {
data: transformData(
- responseText,
+ Buffer.concat(responseBuffer).toString('utf8'),
res.headers,
config.transformResponse
),
@@ -83,4 +83,4 @@ module.exports = function httpAdapter(resolve, reject, config) {
// Send the request
req.end(data);
-};
\ No newline at end of file
+};
from axios.
@vkurchatkin thank you for your diff. I will apply this and write some tests around it.
from axios.
Related Issues (20)
- Axios sends boundary text even when form data is empty HOT 3
- Progress event does not have lengthComputable property
- test cases fails when the interceptor header exceeds 10 characters
- Form data key of "x-amz-security-token" changes from string key to object {x: { amz: {security: { token: <value> } } } }
- What is the correct version guide of Axios? HOT 2
- SSRF Vulnerability Arising from Axios URL Parsing HOT 3
- Why is the headers attribute of InternalAxiosRequestConfig mandatory?
- Security Vulnerability from follow-redirects HOT 1
- axios V0.28.0 Uncaught ReferenceError: req is not defined at AbortSignal.onCanceled HOT 7
- Network Error in React Native HOT 5
- Axios lib gets detected as a trojan HOT 3
- Can't find variable: axios error thrown on older browser (since v.1.6.8) HOT 1
- Invalid package attestation - 1.6.8 HOT 4
- Axios calculating wrong Content-Length HOT 2
- Information Exposure due to the handling of the Proxy-Authorization header across hosts HOT 1
- The interface has a return value, but the axios report response is undefined
- http req with proxy + ca doesn't work HOT 1
- Axios 500 Error Problem HOT 3
- Security: Axios sends HTTPS data in cleartext to a proxy (regression)
- Proxy environment variables ignored HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axios.