Code Monkey home page Code Monkey logo

Comments (3)

tab00 avatar tab00 commented on August 17, 2024

deployCreate3Upgradable calls deployCreate3Contract:
https://github.com/axelarnetwork/axelar-gmp-sdk-solidity/blob/main/scripts/upgradable.js#L70

However the proxy should be inited, so it should instead call deployCreate3AndInitContract maybe like this:

  const proxy = await deployCreate3AndInitContract(
    create3DeployerAddress,
    wallet,
    proxyJson,
    key,
    additionalProxyConstructorArgs,
    [
      implementation.address,
      wallet.address,
      setupParams,      
    ],
    gasLimit,
  );

from axelar-gmp-sdk-solidity.

tab00 avatar tab00 commented on August 17, 2024

@re1ro what do you think?

from axelar-gmp-sdk-solidity.

tab00 avatar tab00 commented on August 17, 2024

There seems to be a problem with init in Create3Deployer:
https://github.com/axelarnetwork/axelar-gmp-sdk-solidity/blob/main/contracts/deploy/Create3Deployer.sol#L53

I get "processing response error" when I attempt deployment, and then transaction reverts.
Deployment works if I comment out that (and next) line, but it's not usable because it hasn't been inited.

There is no such problem when deploying with CREATE2 - init works.

from axelar-gmp-sdk-solidity.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.