Code Monkey home page Code Monkey logo

Comments (3)

jaheba avatar jaheba commented on May 25, 2024 1

A bit embarrassing, but there was a bug in Cached: #3060

from gluonts.

lostella avatar lostella commented on May 25, 2024

@shchur thanks, great reproducer!

What puzzles me is that extrapolating the validation data loader constructor gives me the right length (i.e. number of validation batches) every time I go through them:

from gluonts.itertools import Cached

module = estimator.create_lightning_module()
transformation = estimator.create_transformation()

transformed_validation_data = transformation.apply(val, is_train=True)
transformed_validation_data = Cached(transformed_validation_data)

validation_data_loader = estimator.create_validation_data_loader(
    transformed_validation_data,
    module,
)

print(len(list(validation_data_loader)))
print(len(list(validation_data_loader)))
print(len(list(validation_data_loader)))
print(len(list(validation_data_loader)))

yields

313
313
313
313

from gluonts.

shchur avatar shchur commented on May 25, 2024

Not sure, it looks like some strange interplay with Lightning. I tried dropping a debugger here, and both len(validation_data_loader) and len(list(validation_data_loader)) are equal to the expected length. However, the trainer only takes 1 batch from the validation loader.

Could we just replace the Cached wrapper with list?

if cache_data:
    transformed_validation_data = list(transformed_validation_data)

from gluonts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.