Expected Behaviour

Domain name input should accept any valid domain name.

Current Behaviour

Domains with TLDs longer than 6 characters, such as .services, are rejected.

Code snippet

✔ Do you own a domain name that you would like to use? › Yes


? Please provide your domain name in the following formats: www.mydomainname.com or mydomainname.com ? › test.services
› Domain name format must be www.mydomainname.com or mydomainname.com

  /^[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,6}$/i;

  /^[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,}$/i;

Use case

granted this seems to be beta phase in development, but it would be good to remove the step functions from the pipeline

Solution/User Experience

step functions in pipelines are a temporary solution to something that should be native/built-in steps/actions in CodePipeline.

This will make for a more standard pipeline flow without the need for custom step functions.

Action structure reference

ActionTypeId:
      Category: Invoke
      Owner: AWS
      Version: 1
      Provider: CloudFrontHosting    
Configuration:
      CloudFrontHostingAction: UpdateKeyValue

ActionTypeId:
      Category: Invoke
      Owner: AWS
      Version: 1
      Provider: CloudFrontHosting    
Configuration:
      CloudFrontHostingAction: Purge


## Or a simple consolidated action
ActionTypeId:
      Category: Invoke
      Owner: AWS
      Version: 1
      Provider: CloudFrontHosting    
Configuration:
      Phase: alpha|beta|prod

Expected Behaviour

standardised/harmonised best practice, consider the following AWS Guidance on Organization best practices for production.
CDK

Amplify

CodeCatalyst

Current Behaviour

Code snippet

Organization best practices documented here: https://docs.aws.amazon.com/cdk/v2/guide/best-practices.html

Possible Solution

Standardise the best practice CICD workflow.

Steps to Reproduce

Check the AWS doco

Expected Behaviour

I used the default next.js starter kit npx create-next-app@latest nextjs-blog --use-pnpm --example "https://github.com/vercel/next-learn/tree/main/basics/learn-starter"

My expected behaviour would be that the deploy step is deploying the static files.

Current Behaviour

The build step fails with the following logs:

[Container] 2024/06/05 06:01:35.090350 Running command npx next export
73 | ⨯
74 | `next export` has been removed in favor of 'output: export' in next.config.js.
75 | Learn more: https://nextjs.org/docs/app/building-your-application/deploying/static-exports
76 |  
77

1. `npx create-next-app@latest nextjs-blog --use-pnpm --example "https://github.com/vercel/next-learn/tree/main/basics/learn-starter"`
2. `cloudfront-hosting-toolkit init`
3. `cloudfront-hosting-toolkit deploy`

Expected Behaviour

it works

Current Behaviour

your doco is wrong, and it doesn't work. fix it you Billion $ company!

Code snippet

yeah nah

Possible Solution

No response

Steps to Reproduce

fix is

Exciting to see a new tool in this space.

Use case

As a someone interested in this tool I'd like to know about current and planned support for the "default" next.js and and remix support

Solution/User Experience

Next.js and Remix docs both nudge devs to a architecture that includes a lambda. Next has "static export" and Remix has "spa mode" which are compatible with cloudfront-hosting-toolkit now - but these are not defaults.

Make current and planned support clearer in the readme or roadmap.

Alternative solutions

No response

Other thoughts

I can see in the roadmap there are plans to support SSR. Does this include running code on lambdas like next.js' api routes or remix (not spa mode)?

Hosting next.js serverlessly is notoriously difficult, so I'd understand if that wasn't planned 😅. Remix is supposed to much easier, though I haven't done it myself.

Expected Behaviour

A Route53 A record with alias target, targeting the Cloudfront domain.

Current Behaviour

A Route53 A record with alias target, targeting a substring of Cloudfront domain.

Code snippet

N/A

Possible Solution

When the alias record is created, the a record target should be the cloudfront domain name. However, there's a bug where the first 8 characters of the domain name are omitted:

const cFCNAMEExists = await checkCFCNAMEExists(
  hostingConfiguration.domainName,
  domainName.substring(8),
  hostingConfiguration.hostedZoneId
);

Expected Behaviour

fixed

Current Behaviour

not fixed

Code snippet

fix it

Possible Solution

fix it

Steps to Reproduce

fix #3

try npm i

Use case

When using AWS CDK to create CI/CD pipelines for multiple branches in a repository, we need to create separate pipelines for each branch within the same AWS account.

However, the current implementation generates pipeline names in the format [repoOwner]-[repoName], which leads to the error "[pipeline name] already exists" when trying to create additional pipelines for the same repository.

This limits us to creating only one pipeline per repository in a single AWS account.

Solution/User Experience

Enhance the pipeline creation functionality in AWS CDK to support multiple pipelines per repository within the same AWS account.

This would allow users to set up separate pipelines for different branches or environments without the need for multiple AWS accounts.

Alternative solutions

No response

Expected Behaviour

npm i -g @aws/cloudfront-hosting-toolkit does not install the binary as expected

Current Behaviour

Running both:

npm i -g @aws/[email protected]

or

npm i -g @aws/[email protected]

Produces the following warning and the binary is not created:

Failed to create bin at <project>/node_modules/.bin/cloudfront-hosting-toolkit. ENOENT: no such file or directory, open '<project>/node_modules/@aws/cloudfront-hosting-toolkit/bin/cli/index.js'

It seem to work for version 1.1.9 (npm i -g @aws/[email protected])

Code snippet

npm i -g @aws/cloudfront-hosting-toolkit@1.1.11


or

```bash
npm i -g @aws/cloudfront-hosting-toolkit@1.1.10

### Possible Solution

Looks like the `bin/cli/index.js` file is not included in the package published on npm

### Steps to Reproduce

```bash
npm i -g @aws/[email protected]

npm i -g @aws/[email protected]

Expected Behaviour

Successful deploy.

Current Behaviour

We were attempting to deploy a static (HTML/CSS only) website, and the deploy aborted with the following error:

❌ hosting-main-www-guthries-com-main failed: Error: The stack named hosting-main-www-guthries-com-main failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: 1 validation error detected: Value at 'pipeline.stages.1.member.actions.1.member.namespace' failed to satisfy constraint: Member must satisfy regular expression pattern: [A-Za-z0-9@-_]+ (Service: AWSCodePipeline; Status Code: 400; Error Code: ValidationException; Request ID: 8ad71865-afd2-4f77-9e88-4928bd3eecb7; Proxy: null)
at FullCloudFormationDeployment.monitorDeployment (/usr/lib/node_modules/@aws/cloudfront-hosting-toolkit/node_modules/aws-cdk/lib/index.js:451:10568)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Object.deployStack2 [as deployStack] (/usr/lib/node_modules/@aws/cloudfront-hosting-toolkit/node_modules/aws-cdk/lib/index.js:454:199716)
at async /usr/lib/node_modules/@aws/cloudfront-hosting-toolkit/node_modules/aws-cdk/lib/index.js:454:181438

We're using 'fish' shell, but also tried 'bash' shell.

AWS CLI aws-cli/2.0.17 Python/3.7.3 Linux/5.15.153.1-microsoft-standard-WSL2 botocore/2.0.0dev21

(will try upgrading)

Code snippet

`cloudfront-hosting-toolkit deploy`

Possible Solution

The problem is the 'period' or 'full stop' in our Git repo name. We regularly name our Git repos after app domains / applications etc. Like guthries.com, or www.foo.com etc., This causes the pipeline to fail with an invalid namespace name that contain the period character - which is not in this regex pattern: [A-Za-z0-9@-_]+ The cli and generated outputs need to be escaped to remove periods or special characters and replace them with the allowed characters of the regex expression. I'm guessing that maxLength should be checked as well.

Steps to Reproduce

cloudfront-hosting-toolkit init
cloudfront-hosting-toolkit deploy

Use case

I would like to use the CloudFront Distribution domain to configure a Congito User Pool Client.

Solution/User Experience

I would like to be able to do:

const { distribution } = new Hosting(this, 'Hosting', {...});

Alternative solutions

Currently, I have used `tryFindChild` on the construct node itself to drill down to what I need.

Use case

Example TODO app would help consolidate the concept

Solution/User Experience

• Something vanilla with webcomponents so that we don't have to maintain React/Angular versions. Maybe Typescript with esbuild so that the full CDK stack + app can be TS.

• When you provide the example app, think about testing in the CICD pipeline.

• Run the Jest test for the CDK.
• Unit Tests
• Integration tests
• UI tests

• Since you're providing a CICD concept

• show best of breed DevSecOps tests
• JUnit reports which are supported in CodePipeline.
• Should have monitoring of pipeline
• Should have best of breed opinions on manual approvals & alerts
• Should have monitoring of app once deployed
• Should have app metrics in the monitoring

• leverage Blue/Green/Canary deployments with CodeDeploy.

• If not why not?

• Provide a more advanced example that has a backend.

Alternative solutions

No response