Code Monkey home page Code Monkey logo

Comments (3)

GerardKetuma avatar GerardKetuma commented on May 30, 2024 1

There is a bug in the s3-bucket-helper function s3BucketWithLogging on the following line:

Currently it is:
bucketprops = DefaultS3Props;

But it should be:
bucketprops = DefaultS3Props(); as DefaultS3Props is a function that returns an object and bucketprops should be an object.

I'm creating a PR to resolve the issue.

from aws-solutions-constructs.

robertd avatar robertd commented on May 30, 2024

When I try to override the property...
image

I'm getting a warning:

WARN AWS_SOLUTIONS_CONSTRUCTS_WARNING: An override has been provided for the property: undefined.

from aws-solutions-constructs.

hnishar avatar hnishar commented on May 30, 2024

robertd@ the PR has been merged and that should fix the override warning message..

Regarding the autocomplete issue, CloudFrontToS3Props has cloudFrontDistributionProps declared as cloudfront.CloudFrontWebDistributionProps | any.. due to the any type the IDE is probably not doing the autocomplete.. the any type is required otherwise the caller will need to set the mandatory originConfigs property of S3 bucket that is yet to be created by the pattern

from aws-solutions-constructs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.