Code Monkey home page Code Monkey logo

Comments (5)

brycahta avatar brycahta commented on May 27, 2024 1

The use case I had in mind was creating multiple instances in the same VPC. Maybe I want to be able to ssh to both during development, but then update SG permissions on one instance down the road. If we remove creating ssh-only SG per instance, then users will either need to create SG ahead of time (not simple!) or create/associate a new SG when it comes time to update the instance permissions (if they reused existing). Also, creating a new simple-ec2 SG would only add flexibility because users would still be able to choose an existing simple-ec2 SG if it aligns with their use case. I don't know how practical this or other use cases involving, but I'm erring on the side of flexibility due to that uncertainty.

Last note, these simple-ec2 SGs are just starting points and aren't guaranteed to stay the same. Correct me if I'm wrong, but I think if I requested a simple-ec2 instance and update its SG to remove ssh-only, then try to request another simple-ec2 instance there's a chance I can neither select nor create an ssh-only SG.

from aws-simple-ec2-cli.

snay2 avatar snay2 commented on May 27, 2024 1

Great points, thanks @brycahta!

Given that we have at least one well-reasoned usecase for wanting multiple simple-ec2 SGs, I say we go ahead with allowing them and using unique names for each.

from aws-simple-ec2-cli.

brycahta avatar brycahta commented on May 27, 2024

Multiple SSH security groups can be created

+1. Only callout is to ensure the generated GroupName adheres to CloudFormation constraints:

GroupName
The name of the security group.

Constraints: Up to 255 characters in length. Cannot start with sg-.

Constraints for EC2-Classic: ASCII characters

Constraints for EC2-VPC: a-z, A-Z, 0-9, spaces, and ._-:/()#,@[]+=&;{}!$*

from aws-simple-ec2-cli.

snay2 avatar snay2 commented on May 27, 2024

Do we need to be able to create multiple Simple-EC2 security groups in a single VPC in the first place? I'm not sure this is necessary, and I'd lean more toward disabling the option to create a new SG if one already exists. For me personally, if my existing SG stopped working or didn't meet my needs, I would go delete it before using Simple-EC2 to create a new one.

from aws-simple-ec2-cli.

snay2 avatar snay2 commented on May 27, 2024

This has been released in v0.8.2.

from aws-simple-ec2-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.