Comments (4)
I see that I can override the default exception handler via SQSMessageConsumerBuilder
's withExceptionHandler
. But having a sleep state in SQSQueueUtils.DEFAULT_EXCEPTION_HANDLER
would still be a safer default. For instance, there seems to be the same problem in AmazonSQSRequesterClient
, and I don't see a way to set an exceptionHandler for it to override the default one (I guess that would be a related feature request).
from amazon-sqs-java-temporary-queues-client.
Definitely not a bad idea to handle this better. There's already a sleep in place for QueueNotFoundException
s for a similar reason. :) https://github.com/awslabs/amazon-sqs-java-temporary-queues-client/blob/master/src/main/java/com/amazonaws/services/sqs/util/SQSMessageConsumer.java#L126
That's a little more straight-forward, though, since that exception means it's very unlikely that immediately retrying will succeed. I wouldn't want to assume that about all exceptions, so I'm nervous about introducing an unconditional sleep. Perhaps we could hook up a configurable RetryPolicy? https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/retry/RetryPolicy.html
from amazon-sqs-java-temporary-queues-client.
Whatever the mechanism, I think the most important is that the error handling is in the library user's control, which it is for consumers, but not for requesters. If I can override the default, I guess it wouldn't matter to me what the default behaviour was. (But yes, a RetryPolicy does look like a nice way to go.)
from amazon-sqs-java-temporary-queues-client.
Hi, anyone fixing this ?
from amazon-sqs-java-temporary-queues-client.
Related Issues (20)
- Setup CI for Github project
- Upgrade to JUnit 5
- Implement the async version of the SQS API HOT 1
- Bug receiveMessage on a virtual queue only heartbeats at start of call
- Max Idle Queue Retention Period is set to 5 minutes HOT 1
- Reduce TPS to tagging actions in AmazonSQSIdleQueueDeletingClient HOT 1
- Separate request/response queues? HOT 1
- Orphaned message warnings HOT 1
- SQS tag length exceeded
- Failover SQS client
- Ability to create virtual queues with custom Tags HOT 1
- IdleQueueSweeper with incorrect log classname HOT 1
- SQSMessageConsumer causes ForkJoinPool.commonPool-worker java.security.AccessControlException
- Describe mechanism used when receiving response
- Empty virtual queues are not deleted HOT 6
- Snyk Vulnerabilities HOT 1
- AWS Temporary Queues support for . Net (C#) HOT 1
- Virtual queue cannot subscribe to SNS topic
- messages are not processed
- Unexpected exception during execution of AmazonSQSRequester sendMessageAndGetResponse
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amazon-sqs-java-temporary-queues-client.