Code Monkey home page Code Monkey logo

Comments (12)

amzn-choeric avatar amzn-choeric commented on June 5, 2024 2

We will release 1.3.3 through DLC with an ETA of tomorrow.

The associated SDK change can be tracked through #4335. However, you can also just reference the image URIs specifically to avoid waiting for an SDK release. Available tags and sample image URI can be found here: https://github.com/aws/deep-learning-containers/releases?q=tgi&expanded=true.

from sagemaker-python-sdk.

philschmid avatar philschmid commented on June 5, 2024 1

1.3.1 should be released in the sdk by now. #4314

@LvffY can you share why 1.3.3? This could help us accelerate the release

from sagemaker-python-sdk.

amzn-choeric avatar amzn-choeric commented on June 5, 2024 1

I believe HuggingFace has requested that we hold until they are able to merge the fixes in for huggingface/text-generation-inference#1334.

from sagemaker-python-sdk.

Michellehbn avatar Michellehbn commented on June 5, 2024 1

hi! A fix has been applied for huggingface/text-generation-inference#1334. cc @philschmid

from sagemaker-python-sdk.

cfregly avatar cfregly commented on June 5, 2024

I believe @philschmid mentions that we're waiting for this PR to be accepted: #4314

image

from sagemaker-python-sdk.

LvffY avatar LvffY commented on June 5, 2024

@cfregly I don't think we're waiting for the same version because @philschmid seemed to wait for 1.3.1 version while I'D like to see the 1.3.3 version

But I may look into this PR to see if I can update the sdk myself if anyone answer here :)

from sagemaker-python-sdk.

LvffY avatar LvffY commented on June 5, 2024

@philschmid The main idea is to be able to run Mistral 0.2 models. For now, with all supported versions are throwing the issue described in the huggingface repostory.

Looking at the comments, we see that this should be fixed with this PR which is included in the latest released version 1.3.3

from sagemaker-python-sdk.

cfregly avatar cfregly commented on June 5, 2024

Confirmed that 1.3.1 (SageMaker Python SDK 2.200.1) still throws the same error.

from sagemaker-python-sdk.

amzn-choeric avatar amzn-choeric commented on June 5, 2024

Noting that the reason we are not able to fetch a v1.3.3 image through the SDK is because there is no actual DLC release in itself for v1.3.3. It is not a bug in the SDK from what I have read so far.

from sagemaker-python-sdk.

LvffY avatar LvffY commented on June 5, 2024

Noting that the reason we are not able to fetch a v1.3.3 image through the SDK is because there is no actual DLC release in itself for v1.3.3. It is not a bug in the SDK from what I have read so far.

So what should be the way to go here ?

from sagemaker-python-sdk.

pangyiwei avatar pangyiwei commented on June 5, 2024

@amzn-choeric Is it possible to release 1.3.4 through DLC as well?

1.3.4 has a fix for this issue which will allow some Mistral models (with flash attention v2) to run on instances with non Ampere GPU

from sagemaker-python-sdk.

amzn-choeric avatar amzn-choeric commented on June 5, 2024

I believe that would need to be included in a new release version as deemed appropriate where we can then discuss with HuggingFace about the next steps after.

With regards to the issue at hand, though, it does look like the SDK change has been merged. Thus, closing the issue.

from sagemaker-python-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.