Code Monkey home page Code Monkey logo

Comments (9)

max-rocket-internet avatar max-rocket-internet commented on May 19, 2024 1

It takes many hours for the stable charts to be published on GPC

It takes less than a minute in our CI with many more charts, feel free to copy it: https://github.com/deliveryhero/helm-charts/blob/master/.github/workflows/push-chart.yaml

😃

from eks-charts.

jwenz723 avatar jwenz723 commented on May 19, 2024 1

I would love to see this functionality built in as well. My PR, #472, got merged 11 days ago by @fawadkhaliq. I still cannot make use of the features in my PR because a released version of the helm chart has not been published yet.

from eks-charts.

jaypipes avatar jaypipes commented on May 19, 2024

Not sure about every merge to master, but I suppose I could support auto-publish/index when a new tag is pushed to the master repos of the underlying projects

from eks-charts.

max-rocket-internet avatar max-rocket-internet commented on May 19, 2024

No, I mean like someone makes a PR to update a chart in this repo. The PR is reviewed, the chart version is bumped and the the PR is merged. At this point, we can see it in master but we can't use it as it hasn't been published yet. That is what those 2 issues above are about.

My point is: once a PR has been approved and merged, it should be published and available to use via Helm immediately. That's how the main stable charts repo does it. It's confusing if people have to wait until a tag is created for this whole repo. See what I mean?

from eks-charts.

stefanprodan avatar stefanprodan commented on May 19, 2024

It takes many hours for the stable charts to be published on GPC. The current publishing flow allows us to bundle several PRs in a release and have a change log in GitHub releases. I think it's the reviewer responsibility to do a release or not after the merge and also document the changes.

from eks-charts.

max-rocket-internet avatar max-rocket-internet commented on May 19, 2024

@jaypipes @M00nF1sh @fawadkhaliq can we address what I mention in this issue?

It's so frustrating having to push to get a chart update merged and THEN have to wait/push for a new release to be made.

Another example is #345

Not sure about every merge to master

Why not? That's a totally normal work flow. The old Helm stable repo did this and I don't know how bitnami do it but a PR merged 2 hours ago is already in their index 😅

from eks-charts.

max-rocket-internet avatar max-rocket-internet commented on May 19, 2024

@kishorj @bwagner5

Look at all these issues that could be prevented:

#272
#281
#247
#244

from eks-charts.

max-rocket-internet avatar max-rocket-internet commented on May 19, 2024

And more

#185
#193

I think you get my point 🙂

from eks-charts.

kazu avatar kazu commented on May 19, 2024

when will the newer version including the aws-for-fluent-bit chart (> 0.1.7) publish?
these PR already is merged to master

#446
#492
#353
#491

from eks-charts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.