Code Monkey home page Code Monkey logo

Comments (4)

willarmiros avatar willarmiros commented on July 19, 2024 1

Hi @corey-cole - thanks for the request and for raising the Lambda powertools as an option. We are open to a PR for this enhancement, otherwise it will be on our backlog for now.

from aws-xray-sdk-python.

leandrodamascena avatar leandrodamascena commented on July 19, 2024 1

I see now that there's a issue listing big changes to v3, so if there's no option other than to a breaking change, I think we might as well add this in v3.

#261

from aws-xray-sdk-python.

corey-cole avatar corey-cole commented on July 19, 2024

Incremental suggestion: The AWS Lambda Powertools are packaged such that it excludes boto3 etc, but users can include the SDK if desired (i.e. for local testing). https://github.com/awslabs/aws-lambda-powertools-python/releases/tag/v2.0.0

For example, installing locally and letting pip pick out the associated version of boto3 is managed via pip install aws-lambda-powertools[aws-sdk]

from aws-xray-sdk-python.

leandrodamascena avatar leandrodamascena commented on July 19, 2024

Hi XRay team! I was wondering here if I could work on this and submit a PR. This is actually a huge improvement for anyone using the Lambda Runtime or even another container that comes with botocore as we can take ~77MB out of the deployment package.

I've been using the XRAY SDK for Python for a long time, but this is the first time I've seen the build package and tests. I see that in install_requires you always include botocore, and I don't think we can create a tiny package without a potential breaking change for the non-Lambda runtime, which brings botocore by default. We can remove botocore and add extras_require as an optional dependency, but this will be a potential breaking change for those who just type pip install aws-xray-sdk.
I thought we could create an extras_require that would install something by default, but it looks like setuptools doesn't support that - pypa/setuptools#1139.

Do you know if there is another alternative to solve this? It might be interesting if we can find a solution to do this without a breaking change.

Thank you

from aws-xray-sdk-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.