Code Monkey home page Code Monkey logo

Comments (9)

haotianw465 avatar haotianw465 commented on July 18, 2024

The actual query string capture was originally in the PR submitted by @therealryanbonham, but we requested that part of logic to be removed and submitted with a separate PR.

The actual query might contain sensitive user information and we will have to require the query capture PR to be sanitized and reviewed by our security team to make sure no sensitive user data can sneak into the captured data.

We haven't receive the separate PR yet but I will ping @therealryanbonham to check if there is any recent plan on the query capture.

from aws-xray-sdk-python.

harveyslash avatar harveyslash commented on July 18, 2024

can you link me to that PR ?
I dont mind having some sensitive information being sent.
I would like to see if I can use X ray for my application right now.

from aws-xray-sdk-python.

haotianw465 avatar haotianw465 commented on July 18, 2024

Yes sorry I forget to put that link on. #14

from aws-xray-sdk-python.

haotianw465 avatar haotianw465 commented on July 18, 2024

Hi @harveyslash just want to let you know that the PR for query capture is submitted: #34. Please feel free to try it out and provide any feedback under that PR.

from aws-xray-sdk-python.

harveyslash avatar harveyslash commented on July 18, 2024

I installed that using:
pip install --upgrade git+https://github.com/therealryanbonham/aws-xray-sdk-python.git

And it doesnt seem to have changed anything.

I am not getting the actual query in my X-ray console

from aws-xray-sdk-python.

therealryanbonham avatar therealryanbonham commented on July 18, 2024

You need to include the branch..

git+https://github.com/therealryanbonham/aws-xray-sdk-python.git@sqlalchemy_query#egg=aws-xray-sdk

from aws-xray-sdk-python.

harveyslash avatar harveyslash commented on July 18, 2024

just tried the branch, now im getting :

File "venv/beatest-flask-rest-backend-36/lib/python3.6/site-packages/aws_xray_sdk/core/emitters/udp_emitter.py", line 55, in _send_data
self._port))
OSError: [Errno 40] Message too long

And my X-ray console doesnt show the requests that had the message too long error.
I about 15 fields in my table, so the sql query could be fairly long

from aws-xray-sdk-python.

haotianw465 avatar haotianw465 commented on July 18, 2024

The default UDP packet size is usually 64KB but it might vary on different OS. You can consider to increase this limit.

You can also change streaming_threshold to a lower value so that some data is streamed out earlier:
xray_recorder.configure(streaming_threshold=10)

See https://github.com/aws/aws-xray-sdk-python/blob/master/aws_xray_sdk/core/recorder.py#L118. The default value is 30 which means a segment will stream out its children subsegments when the total children count reaches 30. You can change to 10 or even lower to fit your use case.

from aws-xray-sdk-python.

haotianw465 avatar haotianw465 commented on July 18, 2024

Since the PR for query capture is already out #34, I will close this in favor of the PR to make sure we have a single place to track feedback, concerns and progress regarding this new feature.

If you have other questions regarding the SDK usage in general, feel free to post on our forum https://forums.aws.amazon.com/forum.jspa?forumID=241 or open new issues. But feel free to leave any comments here if you still have concerns.

from aws-xray-sdk-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.