aws-xray-sdk-core increased size due to aws-sdk about aws-xray-sdk-node HOT 4 CLOSED

Hi @jostendorf
The aws-xray-sdk-core package does require the aws-sdk to be present at runtime for the centralized sampling functionality to work, so we can't move it to be a dev dependency.

Are you generating a bundle for your app? #73 will address some of the size concerns by only importing the xray service instead of the entire SDK, though if you're pushing all of node_modules somewhere then you'll still see the entire SDK on disk.

from aws-xray-sdk-node.

I suggest putting the sdk in a lambda layer, so you can deploy once and forget it.

from aws-xray-sdk-node.

You don't need to put the aws-sdk in a lambda layer. You get it for free in the lambda container. I have figured out a way to remove this nested dependency using serverless-webpack. This issue can be closed.

Add this to the custom tag:

packagerOptions:
  scripts:
    - rm -rf node_modules/aws-sdk

from aws-xray-sdk-node.

This is definitely an issue. No reason for this to be here here:

@jostendorf what you posted is an ugly hack of a workaround, not a fix

from aws-xray-sdk-node.