Code Monkey home page Code Monkey logo

Comments (3)

jmklix avatar jmklix commented on August 16, 2024

Hi @laramiel,

I made a PR with your suggested changes here. If this passes all of the tests then we can merge it. We currently don't have any integration tests for bazel and we don't have any plans to add them anytime soon. That being said if you run into any other missing includes please let us know.

from aws-sdk-cpp.

jmklix avatar jmklix commented on August 16, 2024

How are you trying to build this sdk within bazel? Can you share a minimal bazel build files that reproduce the missing includes?

from aws-sdk-cpp.

laramiel avatar laramiel commented on August 16, 2024

Sure, I'll try and get that available at some point. For now, this is a variant of a pull request that we received in tensorstore, but updated to use repositories at github head: google/tensorstore#149

My current attempt includes these repositories:

https://github.com/awslabs/aws-c-sdkutils
https://github.com/awslabs/aws-checksums
https://github.com/awslabs/aws-c-cal
https://github.com/awslabs/aws-c-compression
https://github.com/aws/s2n-tls
https://github.com/awslabs/aws-c-common
https://github.com/awslabs/aws-c-event-stream
https://github.com/awslabs/aws-c-http
https://github.com/awslabs/aws-c-s3
https://github.com/awslabs/aws-c-auth
https://github.com/awslabs/aws-c-mqtt
https://github.com/awslabs/aws-c-io
https://github.com/awslabs/aws-crt-cpp
https://github.com/aws/aws-sdk-cpp

Only a subset of the aws-sdk-cpp repositories are included in the build, and ,ost of the BAZEL.build files are pretty simple, something like:

cc_library(
    name = "aws_c_compression",
    srcs = glob(
        include = [
            "source/*.c",
        ],
        exclude = ["source/huffman_testing.c"],
    ),
    hdrs = glob([
        "include/aws/compression/*.h",
    ]),
    includes = ["include/"],
    deps = [ "@aws_c_common//:aws_c_common" ],
)

from aws-sdk-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.