Code Monkey home page Code Monkey logo

Comments (1)

cogwirrel avatar cogwirrel commented on July 25, 2024

Thanks for raising this! We actually have a test for this case here:

aws-pdk/packages/type-safe-api/test/construct/type-safe-rest-api.test.ts

Lines 164 to 189 in 7afa3b7

it("Create 2 APIs on same stack", () => {
const stack = new Stack(PDKNag.app());
const func = new Function(stack, "Lambda", {
code: Code.fromInline("code"),
handler: "handler",
runtime: Runtime.NODEJS_16_X,
});
withTempSpec(sampleSpec, (specPath) => {
new TypeSafeRestApi(stack, "ApiTest1", {
specPath,
operationLookup,
integrations: {
testOperation: {
integration: Integrations.lambda(func),
},
},
});
new TypeSafeRestApi(stack, "ApiTest2", {
specPath,
operationLookup,
integrations: {
testOperation: {
integration: Integrations.lambda(func),
},
},
});

I suppose the difference here is that the logical ID of the TypeSafeRestApi instances are different, which means the WebACLs have a different name - the names look a bit like: <stack>--<api>-Acl-WebAcl.

I imagine you're encountering this issue when you have different APIs with the same logical ID, just nested under different constructs? As a workaround you should be able to change the logical IDs and they won't conflict.

To address this properly we should do something similar to what we do for the lambda names:

aws-pdk/packages/type-safe-api/src/construct/type-safe-rest-api.ts

Lines 129 to 132 in 7afa3b7

const lambdaNamePrefix = `${PDKNag.getStackPrefix(stack)
.split("/")
.join("-")
.slice(0, 40)}${this.node.addr.slice(-8).toUpperCase()}`;

Or even better we can use the newer CDK Names utility :)

from aws-pdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.