Code Monkey home page Code Monkey logo

Comments (3)

Farmbuyer avatar Farmbuyer commented on July 25, 2024 1

Just a comment from an interested observer: from skimming the linked PR, it looks like the patch will enable retrieving specific keys from sso-session blocks? So given a config file containing

[sso-session sso-personal]
sso_region = ...
sso_start_url = ...

[sso-session sso-homebusiness]
sso_region = ...
sso_start_url = ...

the patch would permit things like aws configure get sso-personal.sso_start_url?

My comment/question is whether it could be extended a little bit to also support some variation on the theme of aws configure list-sso-sessions? Or perhaps a --sso-sessions option flag to the existing configure list-profiles?

I ask because there is no way at present that I can find to extract the "sso-personal" and "sso-homebusiness" labels from the configuration file. (I was hoping to script some management utilities around generating these sections, or at least testing whether a previous aws configure sso-session call had done so, etc.)

from aws-cli.

tim-finnigan avatar tim-finnigan commented on July 25, 2024

Thanks for the feature request. After a quick discussion with the team, we think this probably a reasonable request for the aws configure get command but further review is needed regarding the potential implementation. We would have to account for the config file variations and not introduce any possibly breaking behavior.

from aws-cli.

alexevansigg avatar alexevansigg commented on July 25, 2024

No problem, I had added the unit test for the new functionality.. and whilst here the CI Workflow didn't run yet due to review process, All Pytests executed locally successfully (with Py3.9 + Py3.11).

The only things I thought might perhaps make sense but didn't add was support for was get sso_section attributes using Unqualified Names...

e.g If one Specifies aws configure get sso_start_url --profile abc

This could lookup the values in the 'abc' profile section, if there isn't an sso_start_url key in that profile, then check if it has an sso_section key... if it does use that value to get the respective sso_section and return the sso_start_url value set there.

Also probably a documentation sample could be updated.

from aws-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.