Code Monkey home page Code Monkey logo

Comments (4)

chriszrc avatar chriszrc commented on June 26, 2024

Seems like it's actually setup just fine, the docs here:

https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/EC2.html#describeVolumes-property

Indicate that the "tag-key" filter just looks for a tag with the supplied name, so for a specific volume, you can set "tagKeyValue" to something like "Backup_Enabled" and create a tag with the name "Backup_Enabled" on the volume, and give it whatever value you want (perhaps "true") and it will all work-

from aws-step-functions-ebs-snapshot-mgmt.

cravendy avatar cravendy commented on June 26, 2024

Hello chriszrc, thanks for the reply.

You are correct. Sorry for misunderstanding for the creator's meaning. Author is only to looking for the tag key and not care about the tag value.

However, if line 64 changed to Name: "tag:key" can also be used to specify what key and value to search for.

For example:
tag key: key
tag value: StepFunctionTarget

This will have StepFunction to look for tag key="key" and tag value="StepFunctionTarget" which is also working. Sounds stupid, but, however, it can be configured further at line 64 to "tag:BackupEnabled". Then the effect will be like:

tag key: BackupEnabled
tag value: true (assigned when deploying then cloudformation stack)

Then, we can change the value of the tag anytime to false(as long as it's not true) to turn off backup copy to DR region. The originally way need to rename the tag key or remove the tag completely in order to turn off. Does my thought make sense? maybe a little? lol...

Anyway, my thoughts may cause confusion to people who is watching this. To anyone whom may read the message, please stay to the author's method if you did not understand about the effect between 'tag-key' and 'tag:key'. I don't intend to cause confusion, sorry.

from aws-step-functions-ebs-snapshot-mgmt.

chriszrc avatar chriszrc commented on June 26, 2024

Hi, yes that makes sense, it's true that your approach would allow you to turn off the snapshotting based on the value of the key, rather than having to change the key name or delete the key entirely.

But for someone just starting with this repo, and who isn't familiar with the nuances of the different filters, there's no need to ask them to change the source code, since the example will work fine-

from aws-step-functions-ebs-snapshot-mgmt.

cravendy avatar cravendy commented on June 26, 2024

yes, you're correct. Therefore, I change the title to "some alternative" just for reference. Thank you for reminding.

cheers

from aws-step-functions-ebs-snapshot-mgmt.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.