Bug: openAPI generation - operation requestBody description only on schema output, not at higher level needed for html about powertools-lambda-python HOT 6 CLOSED

Hi @MCR2019 I've tried to use https://redocly.github.io/redoc/ to upload the OpenAPI generated by your code sample, and I see this.

With you change, what would be different in the UI?

from powertools-lambda-python.

Looking at this now

from powertools-lambda-python.

Hi @rubenfonseca , thanks for taking a look at that so quickly and apologies that my example wasn't as accurate as it could be.

I've had another look at it and updated the requestBody so that it uses a Pydantic schema for the type (which is what I would use to enable validation).

example code is now:

from aws_lambda_powertools.event_handler import APIGatewayRestResolver
from aws_lambda_powertools.event_handler.openapi.params import Body, Path
from aws_lambda_powertools.shared.types import Annotated
from pydantic import BaseModel, Extra, Field

app = APIGatewayRestResolver(enable_validation=True)


class ExamplePayloadSchema(BaseModel):
    """Pydantic example payload schema."""

    example_attribute: str = Field(description="Warning limit for remaining IDs.", format="number")

    class Config:
        """Pydantic model config."""

        extra = Extra.forbid


@app.put(
    "/example-resource/<path_parameter>",
)
def put(
        path_parameter: Annotated[str, Path(description="test path description appears at schema and higher level", example="example01")],
        event_body: Annotated[ExamplePayloadSchema, Body(description="test body description only appears at the schema level")]
):
    pass


if __name__ == "__main__":
    openapi_json_schema = app.get_openapi_json_schema()

    with open("openapi_spec_without.json", "w") as json_spec_file:
        json_spec_file.writelines(openapi_json_schema)

this produces the spec:
openapi_spec_without.json

which when an html file is generated using redoc-cli bundle -o openapi/index_without.html openapi/openapi_spec_without.json looks like this:

(There is no description for the request body)

• Manually updating for desired output:

Manually updating the json spec file to include a description in the requestBody (line 46):
openapi_spec_with.json

and generating html file with redoc-cli bundle -o openapi/index_with.html openapi/openapi_spec_with.json gives an html file which shows a description for the request body:

Hopefully that illustrates the issue more clearly, I'll keep looking into what's going on and add more details if I can.

Thanks

from powertools-lambda-python.

This helps a lot! Let me see what's missing on our side.

from powertools-lambda-python.

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

from powertools-lambda-python.

This is now released under 2.31.0 version!

from powertools-lambda-python.