Code Monkey home page Code Monkey logo

Comments (6)

dradetsky avatar dradetsky commented on June 19, 2024

So I think I figured out where that bucketName is empty issue was coming from:

https://github.com/aws-observability/aws-otel-test-framework/blob/deprecating/java-sdk-emitter/src/main/java/com/amazon/aocagent/S3Service.java#L31

Although defining the env variables mentioned here just led to new errors. I note the branch name "deprecating" and have a feeling that asking for support for getting this working is not the right move.

Are there any plans to make newer/better/working sample emitters & thus a good example for devs to use so they can work backwards?

from aws-otel-collector.

mxiamxia avatar mxiamxia commented on June 19, 2024

Hi @dradetsky, thank you for reaching out us. The Java sample app (data emitter) has been moved to a branch and we do lack the good document for it. We'll update our Getting Started docs on it later. Thanks.

To your problems,

  1. bucketName is empty error is a side error which should not impact the functionality of the emitter. Can you please ignore it for now and we're fixing it.
  2. When sample app (Java WebApp) is up, there is a script to make http requests on localhost:4567 to mimic the regular business traffic that will generate Trace data to AWS X-Ray backend via AWS OTel. There is gap when WebApp is fully started before the calls are made. So we see few localhost port 4567: Connection refused at the starting time. We'll fix it.

The two problems you have should not impact Metrics and Traces data to be sent to AWS consoles with the right AWS Credentials. Have your found the data in your AWS account console with Docker Compose example at the end?

Thanks again for the feedbacks and please let us know any issue you have and we'd like to discuss and improve.

from aws-otel-collector.

dradetsky avatar dradetsky commented on June 19, 2024

@mxiamxia fwiw, I managed to get my local environment working by replacing the sample app there with this thing from the js code: https://github.com/aws-observability/aws-otel-js/tree/master/integ-test/js-sdk-emitter.

IMO, that thing is basically as complicated as the sample app needs to be. Even slightly more. As a developer, the very first thing I'm trying to do is figure out whether I have my local environment set up correctly, whether my containers can connect to aws, whether I'm getting my aws credentials loaded properly (see #100 btw), and that sort of thing. I don't yet care about mimicing regular business traffic, I just want a 'hello world xray' kind of thing to let me know my setup works. After that, I might want a sample app that in some way mimics real traffic, but maybe not. In any way, it's nowhere near as important as the sanity-check value provided by a stupid-simple thing like that integration test container.

from aws-otel-collector.

mxiamxia avatar mxiamxia commented on June 19, 2024

I totally agree with you the setup should be simple. Our goal is to have our examples simple enough and developers can also take it as a reference sample code for their applications. Thanks for your contribution (#100) : )

To address some of your feedbacks, we made some improvements on our Java sample app.(if you still need it). It removes all the unexpected errors you've seen and generate Traces and Metrics to AWS. (Documentations are WIP)
https://github.com/aws-observability/aws-otel-collector/pull/101/files

I also sent a PR for creating Metrics with JS SDK to our aws-otel-js aws-observability/aws-otel-js#31. Hope it can provide some help to you. We'll update our Getting Started docs as well soon.

Thanks!

from aws-otel-collector.

dradetsky avatar dradetsky commented on June 19, 2024

@mxiamxia I haven't tried the metrics thing, but it looks like exactly the sort of thing I wanted. Or at least, that I wanted yesterday before I figured it out the hard way. But still, nice!

from aws-otel-collector.

mxiamxia avatar mxiamxia commented on June 19, 2024

Thanks. Closed the issue.

from aws-otel-collector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.