Code Monkey home page Code Monkey logo

Comments (4)

hossain-rayhan avatar hossain-rayhan commented on September 21, 2024

Hi @wyTrivail , I tested the image with Fargate locally and found all the metrics in CloudWatch. However, it would be easy to debug if can answer the followings for me.

  1. Where did you find this?
  2. How to reproduce it?
  3. Wondering, why didn't we catch before merging it? Can we do something so that we can find this earlier. Maybe I missed something.

from aws-otel-collector.

wyTrivail avatar wyTrivail commented on September 21, 2024

Talked with Rayhan offline and found the root cause, which is ecsmetric receiver doesn't properly handle the cluster name getting from Fargate. will wait for Rayhan to fix it before release collector.

To answer the question 3, we can't run the integration test on the PR before merge as it would leak our aws credentials. And you can definitely do something to catch it before merging as you have done using testing framework locally on the EC2 type of ECS, however looks like you didn't run Fargate to validate.

Additionally, i wish we can add some unit tests for this kind of errors when you submit the PR to fix it.

from aws-otel-collector.

hossain-rayhan avatar hossain-rayhan commented on September 21, 2024

PR to address this: open-telemetry/opentelemetry-collector-contrib#1626

from aws-otel-collector.

hossain-rayhan avatar hossain-rayhan commented on September 21, 2024

Closed by #137

from aws-otel-collector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.