Code Monkey home page Code Monkey logo

Comments (8)

robmarkcole avatar robmarkcole commented on July 17, 2024 1

Indeed I just saw that and removed the screenshot :)

from hello-app-runner.

mreferre avatar mreferre commented on July 17, 2024 1

Cool. Yeah I figured that. The way I would use this enhancement would be to have an apprunner.yaml file with some of the core info such as the language runtime, etc and decoupling the env variable for convenience (not secrecy). This is a simple demo app I published today and as you can see the apprunner.yaml file has a variable that describes the region of deployment for a DDB table. I wish I could decouple the core info from this variable (otherwise the user would need to commit a change in the repo to change the region). As I said this is more for workflow convenience than for protecting a secret value (that is, your use case is WAY MORE important).

from hello-app-runner.

robmarkcole avatar robmarkcole commented on July 17, 2024 1

done, thanks!

from hello-app-runner.

mreferre avatar mreferre commented on July 17, 2024

I believe what you are seeing is that IF you select Source code as the repository type AND you select the option to use a configuration file (i.e. apprunner.yaml in the root of the repo) THEN all vars need to be declared inside the file and cannot be specified in at deployment time anymore. In other words it's all or nothing (i.e. if you choose the file, everything needs to be in the file). It would be interesting to consider splitting this and let customers add variables at deployment time (either in addition of those in the config file or instead of putting them in the config file). If you confirm this is what you are seeing I would tweak the title and start tracking this.

from hello-app-runner.

robmarkcole avatar robmarkcole commented on July 17, 2024

Hi @mreferre

Since I use env var for auth strings etc these could not securely be included in apprunner.yaml, unless somehow passed in from a github secret

You suggestion of allowing env var at deploy time would allow a user to fork a repo, then run as is but just dropping in their own env var

from hello-app-runner.

mreferre avatar mreferre commented on July 17, 2024

What you are saying makes a ton of sense to me. However the place where you add the variables is on the next screen. If you click next (where you are above) you should see the option. However, if on this screen you select use configuration file and click next, they won't be there anymore (basically the behavior I described above).

from hello-app-runner.

robmarkcole avatar robmarkcole commented on July 17, 2024

that decoupling does sound useful, you could quickly test an app on dev/prod db for example without code changes

from hello-app-runner.

mreferre avatar mreferre commented on July 17, 2024

Fun fact: I entertained this entire conversation thinking I was on the App Runner roadmap repo :)

If you want to open this issue there please go ahead and we will track it (but I can do that, don't want to steal more of your time).

from hello-app-runner.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.