Code Monkey home page Code Monkey logo

Comments (4)

petmongrels avatar petmongrels commented on September 15, 2024

code review

  • please review the core logic of avoiding sync, if you can see any issues, it is critical.

from avni-server.

himeshr avatar himeshr commented on September 15, 2024

Code review comments, 2 things pending:

  • models version upgrade after groupDashboard apiVersion change
  • Undo StandardReportCardType versioning (Needs discussion)

Additionally, a small Support write-up on handling update of lastModifiedDateTime, to sync Dashboard related entities to old clients, for orgs with change only in old config

from avni-server.

himeshr avatar himeshr commented on September 15, 2024

@petmongrels, Found 1 issue as of now during QA:

  • After deploying 10.0 latest code on prerelease,
  • I had set the following property, export AVNI_ENDPOINT_END_OF_LIFE_1=2024-09-05
  • and restarted the backend server

Inspite of this, on first time sync of AchalaB@shelteruat user, i still received Custom Dashboards with names "Default Dashboard", 'htestdash' and 'htestdash2' which were created /updated on 09-sep-2024, which shouldn't be the case.

Screenshot 2024-09-11 at 6 41 12 PM Screenshot 2024-09-11 at 6 41 27 PM Screenshot 2024-09-11 at 6 42 31 PM

from avni-server.

himeshr avatar himeshr commented on September 15, 2024

Its now Working as designed..
Pending tasks before deployment:

  • Write up for implementation team on how to handle sync for new changes post EndOfLifeDate that do not use 10.0 features
  • Configuring the EndOfLifeDate suitably on avni-server as part of infra

from avni-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.