Code Monkey home page Code Monkey logo

Comments (12)

sindresorhus avatar sindresorhus commented on May 21, 2024

This will probably be easier when #1 is implemented. AVA will then run tests in separate sub-processes.

from ava.

Qix- avatar Qix- commented on May 21, 2024

That'll prevent coverage tests from working.

from ava.

sindresorhus avatar sindresorhus commented on May 21, 2024

No: https://github.com/bcoe/nyc

from ava.

Qix- avatar Qix- commented on May 21, 2024

👍 Starred. Istanbul is what I use and it doesn't; figured that was a global thing.

from ava.

SamVerschueren avatar SamVerschueren commented on May 21, 2024

Should AVA already work with nyc? Trying it out right now but it reports no coverage at all which is quite odd.

from ava.

sindresorhus avatar sindresorhus commented on May 21, 2024

We want AVA to work with it, but I haven't tested. Not a top priority right now as we're focusing on finishing the API and performance. Happy to receive some help debugging/PR/etc, though.

from ava.

sindresorhus avatar sindresorhus commented on May 21, 2024

@Qix- We're now forking each test file. Any recommendation on how we should handle this?

from ava.

Qix- avatar Qix- commented on May 21, 2024

No idea how signals work with threads. Id have to do some research.

from ava.

sindresorhus avatar sindresorhus commented on May 21, 2024

@Qix- We're not using threads (there are no threads in JS), but subprocesses.

from ava.

Qix- avatar Qix- commented on May 21, 2024

Well right. I'd assume each fork would have to register its own signals. I've never done that before, but I'm pretty sure it's analogous to how it works on the native level. And then there's windows...

from ava.

sindresorhus avatar sindresorhus commented on May 21, 2024

fork in the Node.js sense is just a spawned Node.js process with an IPC channel. So it's just a normal child process with normal process signals. I think the best solution here is to just do nothing. If a test file has a SIGSEGV it will just fail the test file, not all the test files.

from ava.

Qix- avatar Qix- commented on May 21, 2024

Fair enough. It's an edge case but maybe when the core is a little more stable in terms of the other forking issues that are open, perhaps we can reconsider this. 👍

from ava.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.