Code Monkey home page Code Monkey logo

Comments (2)

WobbyChip avatar WobbyChip commented on August 16, 2024

I think I found the issue, I am not sure, but I assume if modifier.multiplier is the chance passed in the yml, then this makes sense, since chance *= (100 - 99) will still be 100, when chance *= (100 - 100) will be 0. And in this case, a chance for a rocket to not be consumed must be below 100: NumberUtils.randFloat(0.0, 100.0) > chance.

EffectElytraBoostSaveChance.kt

fun handle(event: PlayerElytraBoostEvent) {
    if (McmmoManager.isFake(event)) {
        return
    }

    val player = event.player

    var chance = 100.0

    for (modifier in (modifiers[player.uniqueId] ?: emptyList())) {
        chance *= (100 - modifier.multiplier)
    }

    if (NumberUtils.randFloat(0.0, 100.0) > chance) {
        event.setShouldConsume(false)
    }
}

from ecoenchants.

WobbyChip avatar WobbyChip commented on August 16, 2024

fixed in EffectElytraBoostSaveChance.kt

from ecoenchants.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.