MunkiInstallsItemsCreator and defining the version_comparison_key in recipe about autopkg HOT 6 CLOSED

I'd like to see this too, although I think it'd be preferable to add the
option upstream to makepkginfo instead of the MunkiImporter processor, and
then just feed the processor the additional option(s).

If Greg were willing to accept a patch for this in Munki, then I guess the
next thing MunkiImporter would need is a 'minimum_munkitools_version' input
var...

On 2013-12-01, at 1:54 PM, Hannes Juutilainen [email protected]
wrote:

I would like to see a possibility to define a version_comparison_key for
MunkiInstallsItemsCreator processor in recipe. I've mostly run into this
when an installs item needs to be defined with CFBundleVersion instead of
CFBundleShortVersionString.

I see that MunkiInstallsItemsCreator is calling makepkginfo -f and there's
no options for makepkginfo to do this but the processor could of course
modify the installs item dictionary before returning.

I could take a closer look and create a pull request when I have way to do
this. Any thoughts?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/54
.

from autopkg.

I should clarify, MunkiInstallsItemsCreator and not MunkiImporter.

On 2013-12-01, at 1:54 PM, Hannes Juutilainen [email protected]
wrote:

I would like to see a possibility to define a version_comparison_key for
MunkiInstallsItemsCreator processor in recipe. I've mostly run into this
when an installs item needs to be defined with CFBundleVersion instead of
CFBundleShortVersionString.

I see that MunkiInstallsItemsCreator is calling makepkginfo -f and there's
no options for makepkginfo to do this but the processor could of course
modify the installs item dictionary before returning.

I could take a closer look and create a pull request when I have way to do
this. Any thoughts?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/54
.

from autopkg.

Just for some additional information. I have noticed this issue with Skype as it will download version 6.12 multiple times but that is because Microsoft is updating Skype slightly. For instance, the latest version is now 6.12.60.438 and the previous version I had in my repo was 6.12.59.431 however both were imported originally as 6.12 so of course the newer version looked like a duplicate i.e. Skype___1.dmg, Skype___2.dmg etc...

from autopkg.

Added in #76.

from autopkg.

I suggest you post to autopkg-discuss. It's likely this is simply a CDN issue and not at all related to this.

from autopkg.

Content Delivery Network. Please post on autopkg-discuss.

from autopkg.