Should we implement Python 2 backwards compatibility? about talos HOT 6 CLOSED

Ok it's resolved now. All tests passing for Python versions:

• 2.7
• 3.4
• 3.5
• 3.6

The corresponding Travis build report here.

I will do some QA tomorrow and get it merged with dev. Closing.

from talos.

That's a good idea. I will try right now with my dev branch to see what happens with 2.7 on Travis. By the way, I've removed 3.4 and 3.5 because of the build failure that comes from Travis due to being able to deploy just once per version to pypi (and it was not simple to deal with). Then related with this would be also to add 3.7 to make sure it works.

from talos.

Let me know what happens! Also could you elaborate a bit on this?

I've removed 3.4 and 3.5 because of the build failure that comes from Travis due to being able to deploy just once per version to pypi

I'm sorry I just don't know enough about Travis. Specifically what do you mean about Travis being able to deploy once per version? Thanks!

from talos.

3.7 is not available on Travis looks like, and 2.7 fails on the Cervical Cancer test where spear_reducer() is used. Gives pandas KeyError on val_acc...I'll look into what's causing this...but in other words looks good.

For Travis there is travis.yml where we can simply add the versions of python we want to test with. Then travis will run the procedures for all those versions we list separately. It's very convenient :)

from talos.

@x94carbone ...by the way are you getting all the build fail notices from the dev-mikko branch to your email?

from talos.

@mikkokotila nope! I don’t receive any notifications from the dev-mikko branch (as it should be, no?).

from talos.