automodality / action-clean Goto Github PK

Hello 👋
We have a mysterious error when cleaning the directory in our workflows with this action (using version 1.1.1):

We're using the action in this way:

    steps:
      - name: Clean Directory
        uses: AutoModality/[email protected]

(Can't link to our workflow bc we only have private repos)

Can someone help with that? I'm not really sure where this error comes from.

Have a good day ✌️

Hi!
I tried to do something similar to prevent self-hosted runners from filling up the filesystem and came across your action.

If I use the action I am getting a permission denied error on trying to remove the files. Apparently the docker run does not have sufficient access to the _work dir.
Can this be fixed somehow?

Action log from my workflow:

rm: cannot remove 'Dockerfile': Permission denied
rm: cannot remove 'README.md': Permission denied

Proposal:
Add a cleanup.sh to the image with the rm -rf command and call the cleanup.sh in the action.yml via run.post-entrypoint: '/cleanup.sh'. This ensures that the cleanup task is always run after the workflow is done, wether it fails or not.

Build container for action use: '/home/vschem/actions-runner/_work/_actions/AutoModality/action-clean/v1.1.0/Dockerfile

I am not running this workflow action in a docker environment. Plain old Ubuntu 20.04 LTS system.

The v1 tag is still pointing to v1.0.0 commit. The convention for actions is that v1 tag points to the lastest minor version of the same major version, e.g. v1.1.0.

While running the action-clean github action, I noticed that it failed because I needed to login to docker. Is this truly the case? I've run it plenty of times before without logging into docker, so it just confused me and caught me off guard. I'm logging into docker for other jobs, but I wasn't aware of this requirement.

Btw really love this action -- was a PITA getting "permission" errors beforehand.

Currently this actions doesn't work on mac os runner. It fails with next error:

Error: Container action is only supported on Linux

Is it possible to add support mac os?