Handle unavailable files with no storage/peers better about automerge-repo HOT 7 OPEN

Ah, that should be in already. There is a passing test in there right now, but maybe it's not actually testing what I think it is.

from automerge-repo.

Just spotted it has a network adapter in that test. Will adjust and see what I can sort

from automerge-repo.

OK, that passes too. What situation are you seeing this in?

from automerge-repo.

In here: https://github.com/automerge/automerge.github.io/blob/repo-updates/docs/quickstart.md

I had a version with no StorageAdapter -- if you reload the page then the document no longer exists to load, but if you called change() you'd get the !isReady() error.

Maybe the issue is that if the document is no bueno, we should return null instead of the change function? Maybe it's just a matter of updating what error message is reported?

from automerge-repo.

So in that situation, the unavailable event is firing and handle.doc() would return undefined. It's just that if you don't look for any of those signs, then you get a "not ready" error when you try to change?

from automerge-repo.

from automerge-repo.

Been thinking about this a little today. It kind of goes back to my initial argument about how a user might access a document. There should always be a check done to make sure that the handle contains a valid document before you try to read from it or change it. At the moment that would be:

const handle = repo.find(id);

const doc = await handle.doc();

if (doc) {
  // do things with the handle
} else {
  // there is an error with the document
  console.log(handle.state)
}

There is also handle.whenReady() which at the moment will resolve or throw an error. It doesn't currently reject if the doc becomes unavailable, which it probably should do.

My instinct is that while reading a non-ready document shouldn't throw, changing a non-ready document probably should.

Essentially, the rule should always be "check the document is ready before doing anything with it".

from automerge-repo.