Comments (7)
Ah, that should be in already. There is a passing test in there right now, but maybe it's not actually testing what I think it is.
from automerge-repo.
Just spotted it has a network adapter in that test. Will adjust and see what I can sort
from automerge-repo.
OK, that passes too. What situation are you seeing this in?
from automerge-repo.
In here: https://github.com/automerge/automerge.github.io/blob/repo-updates/docs/quickstart.md
I had a version with no StorageAdapter -- if you reload the page then the document no longer exists to load, but if you called change() you'd get the !isReady() error.
Maybe the issue is that if the document is no bueno, we should return null instead of the change function? Maybe it's just a matter of updating what error message is reported?
from automerge-repo.
So in that situation, the unavailable
event is firing and handle.doc()
would return undefined
. It's just that if you don't look for any of those signs, then you get a "not ready" error when you try to change
?
from automerge-repo.
from automerge-repo.
Been thinking about this a little today. It kind of goes back to my initial argument about how a user might access a document. There should always be a check done to make sure that the handle contains a valid document before you try to read from it or change it. At the moment that would be:
const handle = repo.find(id);
const doc = await handle.doc();
if (doc) {
// do things with the handle
} else {
// there is an error with the document
console.log(handle.state)
}
There is also handle.whenReady()
which at the moment will resolve or throw an error. It doesn't currently reject if the doc becomes unavailable, which it probably should do.
My instinct is that while reading a non-ready document shouldn't throw, changing a non-ready document probably should.
Essentially, the rule should always be "check the document is ready before doing anything with it".
from automerge-repo.
Related Issues (20)
- NodeFSStorageAdapter lock exception on large number of updates. HOT 2
- An unavailable document may just not be found yet
- WebSocket Ready flag should only be set after Open event HOT 2
- Get latest changes as a document instead of a binary HOT 5
- Virus detected in github head! Windows Defender Trojan:Script/Wacatac.H!ml HOT 4
- WebSocket client disconnection HOT 1
- Access to RawString through automerge-repo? HOT 1
- pnpm run dev, pnpm run dev:demo not working HOT 3
- Out of memory errors after creating enough large documents in repo HOT 7
- network sync protocol leaks documentIds to peers HOT 2
- [Svelte] Counter works but Text doesn't HOT 2
- On Peers in Automerge-Repo: Design HOT 2
- When a change event is emitted by the handle the `handle.docSync()` is still the old value HOT 5
- Large enough messages block the main thread for a long time, which can lead to socket timeouts on blocked clients HOT 3
- svelte: provide a way to await the document becoming ready HOT 1
- Repo and WebSocket provider send two responses for a "request" - the first unavailable, the second a sync HOT 1
- Share policy prevents fetching document from sync server
- repo.clone error message suggests using "handle.waitForReady", which doesn't exist
- Add a way to properly close and cleanup automerge-repo HOT 1
- Inactive `DocHandle`s are not evicted from `handleCache`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from automerge-repo.