Code Monkey home page Code Monkey logo

Comments (8)

avatar commented on June 26, 2024

Cheers for looking into this @mchowning I think it might be more the color of the dividers and the padding that is making it look a little funny. Do you mind just checking we're using $primary-ui-05 for the dividers and that the padding is correct as it looks a little tight?

Screen Shot 2022-07-14 at 2 28 45 pm

Thanks!

from pocket-casts-ios.

rviljoen avatar rviljoen commented on June 26, 2024

@adamzelinski I had a look and the ThemedDivider is using the correct color:

pocket-casts-ios/podcasts/Styles.swift

Lines 132 to 137 in 1ed3c5b

struct ThemedDivider: View {
@EnvironmentObject var theme: Theme
var body: some View {
Divider()
.background(ThemeColor.primaryUi05(for: theme.activeTheme).color)

It is missing padding though. Here is the current version:
image

and then with padding of 10 applied:
image

Is 10 enough, or did you have a different value in mind?

from pocket-casts-ios.

avatar commented on June 26, 2024

The padding looks good to me thanks @rviljoen however I think the dividers need to be the width of the screen as it looks funny with the padding on either side

from pocket-casts-ios.

rviljoen avatar rviljoen commented on June 26, 2024

The padding looks good to me thanks @rviljoen however I think the dividers need to be the width of the screen as it looks funny with the padding on either side

@adamzelinski Yes, I agree! I have removed the leading and trailing padding for the dividers:
image

Let me know if this is good to go and I'll submit a PR.

from pocket-casts-ios.

avatar commented on June 26, 2024

the dividers look really great now thanks @rviljoen however, now all the padding looks off. Can we please make sure all the text elements are in alignment. The padding from both edges should be 16pt.

Screen Shot 2022-12-12 at 12 21 23 pm

from pocket-casts-ios.

rviljoen avatar rviljoen commented on June 26, 2024

@adamzelinski Sorry, I missed that! Here's my latest attempt:

image

In addition to fixing the padding, I also added some space between the Navigation Title ("Edit Folder") and the folder name to match your design.

from pocket-casts-ios.

avatar commented on June 26, 2024

Awesome, thanks @rviljoen that's looking great happy with that. I also assume that the close icon will be there too correct as it's not showing in your screenshots

from pocket-casts-ios.

rviljoen avatar rviljoen commented on June 26, 2024

@adamzelinski Yes, the close icon is visible in the app, but does not render in the Xcode view preview as it is not included in each individual view. Here is a render from the app on a real device, with the view controller rendering it:

24A9CB7C-B596-4654-A165-2990A36FAC5A_1_201_a

from pocket-casts-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.