Xcode 9 and Swift 4 about auth0.swift HOT 6 CLOSED

@portellaa there is a PR that updates those dependencies, unless you need to use beta dependencies which I won't be so sure about. The rest looks good so we will merge

from auth0.swift.

sorry, i didn't saw the content of the PRs and none of them refer that in the name 🙂

fine then, no need for PR 😉

can you close the issue when the PR is merged? 🍻

from auth0.swift.

@portellaa the only thing missing is

if #available(iOS 11.0, *) {
    let configuration: SFSafariViewController.Configuration = {
       $0.entersReaderIfAvailable = false
       return $0
    }(SFSafariViewController.Configuration())
    super.init(url: URL, configuration: configuration)
} else {
    super.init(url: URL, entersReaderIfAvailable: false)
}

if you want to make the PR otherwise we will do it next week

from auth0.swift.

yes, i will :) thanks

from auth0.swift.

@portellaa

You should check out the existing swift-4.0-beta branch if you want to have a play in Xcode 9 :)
It already includes your code and also has latest dependencies. I found a few other bugs in Nimble 7.0.1 but commented out those tests for now, so everything will pass.

Have fun.

from auth0.swift.

Awesome @cocojoe 😃 working like a charm.

from auth0.swift.