Remove core-js runtime dependency about metadata HOT 7 CLOSED

Ok, keep me posted. Also, the author of core-js contacted me and may have some ideas too. I bet we can do a combination of things to improve this. I'm interested to see what you put together. Thanks for taking on the challenge!

from metadata.

Before I do a pull request or any CLA stuff, can you please review this commit (which I would submit as is, I think) and see if it's the way you want to go? I don't assume I'd be doing the rest of them, but this would be a start - not sure how much bigger the other repos are and I'd like guidance on how to continue down the path if at all...

https://github.com/MrAndMrsK/metadata/commit/4b23faf2a111624f0accdc6cbbe8d7bbca39c929

Thanks

from metadata.

Let's see if we can get a few other guys to look at this and see what direction we want to go. @jdanyow Take a look at this PR. Any thoughts on this or how we can remove the hard dependency on core-js. Should we remove it entirely and then feature detect and throw like this? It might work. We can still configure core-js by default in the skeles. @PWKad I would appreciate your feedback as well.

@MrAndMrsK There are some other apis we need to check as well. @ahmedshuhel Can you find that list of es6 apis that you created that we rely on?

from metadata.

I wonder if we could add some asserting methods in pal that the various libraries could call to assert that what they need is present.

from metadata.

Yes, it is true that the other aurelia modules also rely on other es6 features, but for this library these were the only two I noticed. I'm proposing that each module, which I assume can be used possibly without their peers (in the aurelia-framework dependency tree) would have their own featureDetect script. If this is missing a check, then it is because I missed its usage.

FYI, to identify es6 features, I merely renamed the compiled output to .ts and brought in the pal.d.ts as a reference. Typescript highlighted the only remaining issues which were usages of Reflect and Map.

(I am a little confused by the type annotations in the compiled /dist/aurelia-metadata.js because I don't think even es7 considers them valid syntax. Should this file actually already be a .ts file?)

from metadata.

agree- lets add some assert methods to the PAL, memoizing as-needed. Need to figure out how to write tests for these as well.

from metadata.

All done :)

from metadata.