Comments (5)
paullryan
commented on June 12, 2024
1
I instrumented the bootstrap handleApp function to print the full stack trace:
Error: Failed to execute 'setAttributeNS' on 'Element': '' is an invalid namespace for attributes.
at Error (native)
at OoPropertyObserver.setValue (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/property-observation.js:200:26)
at InterpolationBinding.setValue (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/binding-language.js:214:35)
at InterpolationBinding.bind (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/binding-language.js:202:22)
at View.bind (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/view.js:65:29)
at ViewFactory.create (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/view-factory.js:173:22)
at BoundViewFactory.create (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/view-factory.js:128:39)
at Repeat.processItems (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/repeat.js:105:36)
at Repeat.bind (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/repeat.js:60:22)
at BehaviorInstance.bind (http://localhost:9000/jspm_packages/github/aurelia/[email protected]/system/behavior-instance.js:67:39)Also if I hack the property-observation code to explicitly set the namespace it works, but this is really kludgy and likely to break quickly.
https://github.com/aurelia/binding/blob/master/src/property-observation.js#L153-L159 changed to:
setValue(newValue) {
if (this.isSVG) {
if(this.propertyName.indexOf('xlink:') >= 0){
this.obj.setAttributeNS("http://www.w3.org/1999/xlink", this.propertyName, newValue);
} else {
this.obj.setAttributeNS(null, this.propertyName, newValue);
}
} else {
this.obj[this.propertyName] = newValue;
}
}from binding.
paullryan
commented on June 12, 2024
Something like the following will work for the interpolation case:
function getAttrNamespace(attributes, propertyName){
let attr = attributes.getNamedItem(propertyName);
if(attr){
return attr.namespaceURI;
}
}
setValue: {
if(this.propertyName.indexOf(':') > 0){
let namespaceURI = getAttrNamespace(this.obj.attributes, this.propertyName);
this.obj.setAttributeNS(namespaceURI, this.propertyName, newValue);
} else if (this.isSVG) {
this.obj.setAttributeNS(null, this.propertyName, newValue);
} else {
this.obj[this.propertyName] = newValue;
}
},But not for the bind case because even if you grab propertyname + ".bind" it won't be bound to the desired namespaceURI yet so you may have to do a global lookup somehow of the the namespaces available to the document.
from binding.
EisenbergEffect
commented on June 12, 2024
@jdanyow Can you look into this and see if we can do work to improve this, possibly through our element observer abstraction?
from binding.
jdanyow
commented on June 12, 2024
sure
from binding.
jdanyow
commented on June 12, 2024
Still researching this. Posted related question here: http://stackoverflow.com/questions/28560100/why-is-getattributenodens-returning-null
from binding.
Related Issues (20)
- path expressions containing 'in' no longer working, 'in' treated as keyword HOT 3
- Issue with aurelia/binding typings HOT 12
- Issue with interpolation binding inside HTML `<option>` element HOT 2
- Checkbox event arguments in repeaters not binding correctly HOT 5
- @behel33 Thanks for creating the issue, I couldn't recreate the behavior you described, can you help fix this codesandbox https://codesandbox.io/s/x761qq5p3q HOT 1
- Infinite loop with 100+ observers HOT 17
- click.delegate bindings stop working HOT 14
- click.delegate firing for all clicks on firefox rather than just left click HOT 5
- Binding on role attribute not working in Firefox HOT 4
- Delegate event bubbling does not match native behavior in shadow dom
- Infinite loop in aurelia-bindingd.ts OverrideContext HOT 13
- parsing of template issue: ${moment().toISOString()} does not work HOT 1
- Parser Error: Invalid start of expression at column 0 in expression []
- Optimizing getter access HOT 1
- Matcher ignored within repeater HOT 7
- Delegate does not support shadow dom for Firefox
- getContextFor() doesn't handle a non-object bindingContext HOT 3
- Can we use/make attached/detached method inside aurelia custom element? HOT 3
- Binding checkboxes: custom matcher does not work when using repeat.for HOT 3
- SetterObserver keeps old value retained HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from binding.