Catch Authentication Errors about robinhood-node HOT 3 CLOSED

This wil be fixed once #105 is implemented

from robinhood-node.

@brycelund I was wondering this also. The module design doesn't allow them to be captured since it throws in an asynchronous manner.

A simple fix would be to update:

1. The throw here
2. Another throw here
3. And here

Replace the throws with:

callback(new AuthenticationError('token missing from response body'))

and

// wrap the network/request errors with VError
callback(new VError(err, 'failed to fetch account')) // line 164/155
callback(new VError(err, 'failed to perform login call')) // line 137

Could be an easy enough PR, but also a breaking change since the login callback would now become callback(error, data) instead of the current callback(data). This would be a good thing since the former is the correct Node.js convention.

from robinhood-node.

Why is this closed @aurbano if it's not fixed yet?

from robinhood-node.